[ 
https://issues.apache.org/jira/browse/HBASE-15999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15324010#comment-15324010
 ] 

Anoop Sam John commented on HBASE-15999:
----------------------------------------

Ideally these thread to be created under the context of handler threads (That 
is what is doing the writes to memstore which in turn may result in in memory 
flushes and usage of this new pool).
"B.defaultRpcServer.handler=89,queue=9,port=16041-inmemoryCompactions-1465492533442"
  -> This seems some of the 1st thread created and ya we can see the format.
Now another thread seems created in the context this thread that is why 
"-inmemoryCompactions-" names getting appened with this name !!  Wondering how?

On the naming I agree we may not need prepend the  handler name. It is not like 
this thread will always handle this Handler thread. It happened to be that this 
Handler initiated an in memory flush and so create of this thread.  Also am not 
sure just adding the TS is enough for better distinguish of threads. Some thing 
like the handler is having , a counter?

> Do not append the current thread name for the threads in the 
> INMEMORY_COMPACTION_POOL
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-15999
>                 URL: https://issues.apache.org/jira/browse/HBASE-15999
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15999.patch
>
>
> In the INMEMORY_COMPACTION_POOL ThreadPoolExecutor for every thread the 
> current thread name is also appended. Since we are using a pool the name gets 
> appended and we end up in names like this
> {code}
> "B.defaultRpcServer.handler=89,queue=9,port=16041-inmemoryCompactions-1465492533442-inmemoryCompactions-1465492548754-inmemoryCompactions-1465492548913-inmemoryCompactions-1465492549625-inmemoryCompactions-1465492549956-inmemoryCompactions-1465492567040-inmemoryCompactions-1465492567160-inmemoryCompactions-1465492578465-inmemoryCompactions-1465492578707-inmemoryCompactions-1465492579292-inmemoryCompactions-1465492579357-inmemoryCompactions-1465492579786-inmemoryCompactions-1465492580059-inmemoryCompactions-1465492589975-inmemoryCompactions-1465492590192-inmemoryCompactions-1465492590484-inmemoryCompactions-1465492591144-inmemoryCompactions-1465492592603-inmemoryCompactions-1465492592799-inmemoryCompactions-1465492597106-inmemoryCompactions-1465492602925-inmemoryCompactions-1465492606620-inmemoryCompactions-1465492651478-inmemoryCompactions-1465492653460-inmemoryCompactions-1465492677020-inmemoryCompactions-1465492680857-inmemoryCompactions-1465492681989-inmemoryCompactions-1465492721818-inmemoryCompactions-1465492723562-inmemoryCompactions-1465492724801-inmemoryCompactions-1465492726665-inmemoryCompactions-1465492745750-inmemoryCompactions-1465492745964-inmemoryCompactions-1465492746578-inmemoryCompactions-1465492756867-inmemoryCompactions-1465492764727-inmemoryCompactions-1465492766944-inmemoryCompactions-1465492767098-inmemoryCompactions-1465492785298-inmemoryCompactions-1465492788334-inmemoryCompactions-1465492795954-inmemoryCompactions-1465493047265-inmemoryCompactions-1465493091530-inmemoryCompactions-1465493185684"
>  #6006 daemon prio=5 os_prio=0 tid=0x000000000daa6800 nid=0x454a runnable 
> [0x00007f50fd0b9000]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to