[
https://issues.apache.org/jira/browse/HBASE-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jurriaan Mous updated HBASE-15978:
----------------------------------
Attachment: HBASE-15978.patch
Made a new abstraction so Netty Future is not leaked through HBase Future.
I cannot find a perfect solution to not leak GenericFutureListener interface in
ResponseFutureListener. Now I marked the implemented method operationComplete
as IA.Private. The only proper way I can think of would be to create separate
instances for both instances but that would lead to a creation overhead each
time a call is done with AsyncRpcClient. Anybody has other suggestions? Or
maybe just accept the creation overhead?
> Netty API leaked into public API
> --------------------------------
>
> Key: HBASE-15978
> URL: https://issues.apache.org/jira/browse/HBASE-15978
> Project: HBase
> Issue Type: Bug
> Components: Client
> Affects Versions: 2.0.0
> Reporter: Nick Dimiduk
> Assignee: Jurriaan Mous
> Priority: Blocker
> Attachments: HBASE-15978.patch
>
>
> Noticed out public
> {{[client.Future|http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Future.html]}}
> interface extends Netty, which means our public API is bound to a specific
> Netty API and release. IIRC we were minimizing our public-facing surface area
> and asserting ownership over the whole of it so as to control our
> compatibility. Ie, we've done this with Protobuf as well. Not sure if this
> has made it back to other branches.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
