[
https://issues.apache.org/jira/browse/HBASE-16016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15328407#comment-15328407
]
Hadoop QA commented on HBASE-16016:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | {color:red} pre-patch {color} | {color:red} 0m 0s
{color} | {color:red} JAVA_HOME is not defined. {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12810062/HBase-16016.v1-master.patch
|
| JIRA Issue | HBASE-16016 |
| Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck
hbaseanti checkstyle compile |
| uname | Linux pietas.apache.org 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT
Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 56c209c |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/2196/console |
| Powered by | Apache Yetus 0.2.1 http://yetus.apache.org |
This message was automatically generated.
> AssignmentManager#waitForAssignment could have unexpected negative deadline
> ---------------------------------------------------------------------------
>
> Key: HBASE-16016
> URL: https://issues.apache.org/jira/browse/HBASE-16016
> Project: HBase
> Issue Type: Bug
> Reporter: Stephen Yuan Jiang
> Assignee: Stephen Yuan Jiang
> Attachments: HBase-16016.v1-master.patch
>
>
> AssignmentManager#waitForAssignment(HRegionInfo regionInfo) passes
> Long.MAX_VALUE deadline and intends to wait forever. However, the deadline
> would be overflowed from AssignmentManager#waitForAssignment(final
> Collection<HRegionInfo> regionSet, final boolean waitTillAllAssigned, final
> int reassigningRegions, final long minEndTime), which would cause no wait!
> {code}
> /**
> * Waits until the specified region has completed assignment.
> * <p>
> * If the region is already assigned, returns immediately. Otherwise,
> method
> * blocks until the region is assigned.
> * @param regionInfo region to wait on assignment for
> * @return true if the region is assigned false otherwise.
> * @throws InterruptedException
> */
> public boolean waitForAssignment(HRegionInfo regionInfo)
> throws InterruptedException {
> ArrayList<HRegionInfo> regionSet = new ArrayList<HRegionInfo>(1);
> regionSet.add(regionInfo);
> return waitForAssignment(regionSet, true, Long.MAX_VALUE);
> }
> /**
> * Waits until the specified region has completed assignment, or the
> deadline is reached.
> */
> protected boolean waitForAssignment(final Collection<HRegionInfo> regionSet,
> final boolean waitTillAllAssigned, final int reassigningRegions,
> final long minEndTime) throws InterruptedException {
> long deadline = minEndTime + bulkPerRegionOpenTimeGuesstimate *
> (reassigningRegions + 1); // ----> OVERFLOW
> return waitForAssignment(regionSet, waitTillAllAssigned, deadline);
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
