[
https://issues.apache.org/jira/browse/HBASE-8075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330027#comment-15330027
]
Stephen Yuan Jiang commented on HBASE-8075:
-------------------------------------------
Sure. I can re-use HBASE-15476 for this patch, as you mentioned in
HBASE-15476, remove the RSRpcServices#closeRegion() preClose CP call is safe.
I hesitate to remove the one in HRegionServer#closeRegion(). The code is there
forever, especially I don't want to un-stablize the 1.x code base.
> HRegion preClose hook is getting called multiple times for single close
> -----------------------------------------------------------------------
>
> Key: HBASE-8075
> URL: https://issues.apache.org/jira/browse/HBASE-8075
> Project: HBase
> Issue Type: Bug
> Components: Coprocessors
> Affects Versions: 2.0.0, 1.3.0, 1.2.1, 1.1.4, 0.98.19
> Reporter: rajeshbabu
> Assignee: Stephen Yuan Jiang
> Fix For: 2.0.0
>
> Attachments: HBASE-8075.v1-master.patch
>
>
> 1) HRegionServer#closeRegion(final RpcController controller,
> final CloseRegionRequest request)
> {code}
> // Can be null if we're calling close on a region that's not online
> final HRegion region = this.getFromOnlineRegions(encodedRegionName);
> if ((region != null) && (region .getCoprocessorHost() != null)) {
> region.getCoprocessorHost().preClose(false);
> }
> {code}
> 2) HRegionServer#closeRegion(String encodedName, final boolean abort,
> final boolean zk, final int versionOfClosingNode, final ServerName sn)
> {code}
> if ((actualRegion != null) && (actualRegion.getCoprocessorHost() !=
> null)) {
> try {
> actualRegion.getCoprocessorHost().preClose(false);
> } catch (IOException exp) {
> LOG.warn("Unable to close region: the coprocessor launched an error
> ", exp);
> return false;
> }
> }
> {code}
> 3) HRegion# private List<StoreFile> doClose(
> final boolean abort, MonitoredTask status)
> {code}
> if (coprocessorHost != null) {
> status.setStatus("Running coprocessor pre-close hooks");
> this.coprocessorHost.preClose(abort);
> }
> {code}
> IMO 3rd one is enough and remaining two are not needed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
