[
https://issues.apache.org/jira/browse/HBASE-16045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334328#comment-15334328
]
Matteo Bertozzi commented on HBASE-16045:
-----------------------------------------
v2 looks ok to me, maybe the && i >= args.length-2 is not necessary since table
names or peer id can't start with --
if you want you can open another jira to check and fix all the tools we have to
add the check.
the one I was sure about the check were hbck, and snapshotinfo. but as you
pointed out we have things that don't check
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java#L4712
https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotInfo.java#L386
> endtime argument for VerifyReplication was incorrectly specified in usage
> -------------------------------------------------------------------------
>
> Key: HBASE-16045
> URL: https://issues.apache.org/jira/browse/HBASE-16045
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Attachments: 16045.v1.txt, 16045.v2.txt
>
>
> Working on a customer case where the following was given for verifyrep:
> {code}
> --starttime=1456790400000 \
> --stoptime=1456876800000
> {code}
> Customer complained that the timestamp of a (sample) row reported as
> ONLY_IN_PEER_TABLE_ROWS corresponded to time outside the time range.
> The code says:
> {code}
> final String endTimeArgKey = "--endtime=";
> {code}
> It turns out that usage String was wrong:
> {code}
> System.err.println("Usage: verifyrep [--starttime=X]" +
> " [--stoptime=Y] [--families=A] <peerid> <tablename>");
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
