[ 
https://issues.apache.org/jira/browse/HBASE-16066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15338450#comment-15338450
 ] 

Yu Li commented on HBASE-16066:
-------------------------------

Since this is a simple and straight-forward fix, allow me to commit this w/o 
review to avoid blocking pre-commit check of other JIRAs.

> Resolve RpC_REPEATED_CONDITIONAL_TEST findbugs warnings in HMaster
> ------------------------------------------------------------------
>
>                 Key: HBASE-16066
>                 URL: https://issues.apache.org/jira/browse/HBASE-16066
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Yu Li
>            Assignee: Yu Li
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16066.patch
>
>
> As titled, find this issue in findbugs report of HBASE-16032:
> {noformat}
> Code  Warning
> RpC   Repeated conditional test in 
> org.apache.hadoop.hbase.master.HMaster.normalizeRegions()
> Bug type RpC_REPEATED_CONDITIONAL_TEST (click for details) 
> In class org.apache.hadoop.hbase.master.HMaster
> In method org.apache.hadoop.hbase.master.HMaster.normalizeRegions()
> At HMaster.java:[line 1388]
> At HMaster.java:[line 1388]
> {noformat}
> And we could find below lines in {{HMaster}} line 1388:
> {code}
>         if (table.isSystemTable() || (tblDesc != null &&
>             tblDesc != null &&
>             !tblDesc.isNormalizationEnabled())) {
> {code}
> where there's a duplicated check, introduced by HBASE-15467



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to