[ 
https://issues.apache.org/jira/browse/HBASE-16036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343038#comment-15343038
 ] 

Hudson commented on HBASE-16036:
--------------------------------

FAILURE: Integrated in HBase-Trunk_matrix #1090 (See 
[https://builds.apache.org/job/HBase-Trunk_matrix/1090/])
HBASE-16036 Made Replication Table creation non-blocking. (eclark: rev 
152594560e29549642587b850320f5d66339b747)
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationTableBase.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManagerZkImpl.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/TableBasedReplicationQueuesClientImpl.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationTableBase.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationStateHBaseImpl.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesArguments.java
* 
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/ReplicationQueuesClientArguments.java
* 
hbase-client/src/main/java/org/apache/hadoop/hbase/replication/TableBasedReplicationQueuesImpl.java
* 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestTableBasedReplicationSourceManagerImpl.java


> Fix ReplicationTableBase initialization to make it non-blocking
> ---------------------------------------------------------------
>
>                 Key: HBASE-16036
>                 URL: https://issues.apache.org/jira/browse/HBASE-16036
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Replication
>            Reporter: Joseph
>            Assignee: Joseph
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16036.patch
>
>
> Currently there is a bug inside of TableBasedReplicationQueuesImpl 
> construction that prevents ReplicationServices from starting before Master is 
> initialized. So currently each of the RS, including HMaster, with Replication 
> enabled will attempt to create the ReplicationTable on initialization. 
> Currently HMaster's initialization: serviceThreads.start() -> new 
> TableBasedReplicationQueuesImpl() -> Replication Table Creation -> HMaster 
> sets initialized flags.
> But this fails when we try to create the Replication Table as the 
> HMaster.checkInitialized() flag fails. This ends up blocking HMaster 
> initialization and results in a deadlock.
> So in this patch, I will create the Replication Table in the background of 
> TableBasedReplicationQueuesImpl and only block when we actually call methods 
> that access it.
> This also requires a small refactoring of ReplicationSourceManager.init() so 
> that we run the abandoned queue adoption in the background
> Review board at: https://reviews.apache.org/r/48763/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to