[
https://issues.apache.org/jira/browse/HBASE-15945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15343750#comment-15343750
]
Sudeep Sunthankar commented on HBASE-15945:
-------------------------------------------
Thanks for the feedback.
Please find my comments and let me know your thoughts on the same.
--- Will use hbase namespace going forward.
--- Let's use std::string for representing Java's byte[]. As Elliott mentioned
even PB uses strings for the same. We can use string references wherever
required.
--- The first patch in this series had exposed all of the KeyValue API's. In
the last one, we derived Cell from KeyValue to hide the implementation details.
Will work on Enis's feedback to remove KeyValue implementation details from the
patch.
--- "if/Cell.pb.h" is added for reusing the CellType enum defined in the PB
instead of redefining the same enums.Should we define our own enums ?
--- We have defined a custom exception class derived from std::exception which
we use to throw exceptions.
--- We have taken care not to add unwanted code. There might be some API's or
functions which provide some functionality but may not be called in the patch.
Should we remove all such functions ?
> Patch for Key Value, Bytes and Cell
> -----------------------------------
>
> Key: HBASE-15945
> URL: https://issues.apache.org/jira/browse/HBASE-15945
> Project: HBase
> Issue Type: Sub-task
> Reporter: Sudeep Sunthankar
> Attachments: HBASE-15945-HBASE-14850.v2.patch,
> HBASE-15945.HBASE-14850.v1.patch
>
>
> This patch contains an implementation of Key Value, Bytes and Cell modeled on
> the lines of Java implementation.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
