[ 
https://issues.apache.org/jira/browse/HBASE-16055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15346058#comment-15346058
 ] 

Anoop Sam John commented on HBASE-16055:
----------------------------------------

bq.Here we will not be having any tags. Because these cells are from Puts. 
currently we don't support Tags to be added with Puts. So should be fine I 
think.
Its not fully true.  Because Put having an add(Cell) API and to that one can 
add any Tags.  Even in normal put op path also, if one uses KVCodecWithTags 
Codec, we can get that even into system also.  So better handle?  Any way 
chances less..  U will have an extra check like getTagsLength()>0

> PutSortReducer loses any Visibility/acl attribute set on the Puts 
> ------------------------------------------------------------------
>
>                 Key: HBASE-16055
>                 URL: https://issues.apache.org/jira/browse/HBASE-16055
>             Project: HBase
>          Issue Type: Bug
>          Components: security
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Critical
>             Fix For: 2.0.0, 1.0.4, 1.4.0, 0.98.21
>
>         Attachments: HBASE-16055_1.patch
>
>
> Based on a user discussion, I think as the user pointed out rightly, when a 
> PutSortReducer is used any visibility attribute or external attribute set on 
> the Put will be lost as we create KVs out of the cells in the puts whereas 
> the ACL and visibility are all set as Attributes. 
> In TextSortReducer we tend to read the information we tend to read the 
> information from the parsed line but here in PutSortReducer we don't do it. I 
> think this problem should be in all the existing versions where we support 
> Tags. Correct me if am wrong here. 
> [~anoop.hbase], [[email protected]]?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to