[
https://issues.apache.org/jira/browse/HBASE-16121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351628#comment-15351628
]
Matteo Bertozzi commented on HBASE-16121:
-----------------------------------------
Did a couple of runs and checked TestAcidGuarantees and TestRegionServerMetric
code.
failures are not related to the patch.
{noformat}
Running org.apache.hadoop.hbase.TestAcidGuarantees
Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 228.425 sec -
in org.apache.hadoop.hbase.TestAcidGuarantees
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m;
support was removed in 8.0
Running org.apache.hadoop.hbase.TestZooKeeper
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 162.274 sec -
in org.apache.hadoop.hbase.TestZooKeeper
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m;
support was removed in 8.0
Running org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 132.596 sec -
in org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m;
support was removed in 8.0
Running org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 248.148 sec -
in org.apache.hadoop.hbase.snapshot.TestSecureExportSnapshot
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m;
support was removed in 8.0
Running org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 59.605 sec - in
org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m;
support was removed in 8.0
Running org.apache.hadoop.hbase.snapshot.TestExportSnapshot
Tests run: 9, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 260.402 sec -
in org.apache.hadoop.hbase.snapshot.TestExportSnapshot
Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m;
support was removed in 8.0
Running org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics
Tests run: 16, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 74.025 sec -
in org.apache.hadoop.hbase.regionserver.TestRegionServerMetrics
{noformat}
> Require only MasterServices to the ServerManager constructor
> ------------------------------------------------------------
>
> Key: HBASE-16121
> URL: https://issues.apache.org/jira/browse/HBASE-16121
> Project: HBase
> Issue Type: Sub-task
> Components: master
> Affects Versions: 2.0.0
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Trivial
> Fix For: 2.0.0
>
> Attachments: HBASE-16121-v0.patch
>
>
> currently we pass Server and MasterServices to the ServerManager.
> MasterServices is a Server and in tests where we try to pass only one of the
> two we end up with NPEs if the code change.
> remove the Server arg and just pass the MasterServices
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)