[ 
https://issues.apache.org/jira/browse/HBASE-16134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354503#comment-15354503
 ] 

Anoop Sam John commented on HBASE-16134:
----------------------------------------

My bad... Missed InternalCell extend Cell..  Will do.
ServersideCell - No....     Because it can be in hbase-common only !!!  Name 
confuses.. ExtendedCell sounds fine to me.  I can change if Stack also ok with 
it.

bq.What about HeapSize, Cloneable? A SuperCell should do these too I'd say?
Can put those also into new Interface.

bq.Agreed that we should remove SettableSeqId and timestamp if we can.
I am not removing them because it is there in 1.x versions.  And it is not 
Private.  I dont think any user creating their own Cell impls. (Phoenix I saw 
in the past .. Some IndexKV or some thing). So deprecate in 2.0.

[[email protected]]  SettableTimestamp came in along with KV -> Cell in read 
path.   In write path we will have to reset the TS on cells (when Cell TS is 
maxTS and we reset it with RS time).   So we want all the Cells flowing through 
write path to have setTimestamp() implemented.
SettableSeqId is used in both R and W paths.


> Introduce InternalCell
> ----------------------
>
>                 Key: HBASE-16134
>                 URL: https://issues.apache.org/jira/browse/HBASE-16134
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16134.patch, HBASE-16134.patch
>
>
> Came after the discussion under HBASE-15721 and HBASE-15879.
> InternalCell is a Cell extension. We do have Cell extensions across different 
> interfaces now.
> SettableSeqId
> SettableTimestamp
> Streamable.
> And demand for this keep growing.
> So let us include everything into one Interface.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to