[
https://issues.apache.org/jira/browse/HBASE-15965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15354631#comment-15354631
]
Hudson commented on HBASE-15965:
--------------------------------
SUCCESS: Integrated in HBase-1.4 #257 (See
[https://builds.apache.org/job/HBase-1.4/257/])
Revert HBASE-15965 and HBASE-15849. While it's fine to introduce these (appy:
rev 48492ec7fd72a89ac67b2ef834ccfa8021fbadd5)
* hbase-shell/src/main/ruby/shell/commands/delete_all_snapshot.rb
* hbase-shell/src/main/ruby/shell/commands.rb
* hbase-shell/src/main/ruby/shell/commands/get_peer_config.rb
* hbase-shell/src/main/ruby/shell/commands/list.rb
* hbase-shell/src/main/ruby/shell/commands/list_replicated_tables.rb
* hbase-shell/src/test/ruby/test_helper.rb
* hbase-shell/src/test/ruby/hbase/replication_admin_test.rb
* hbase-shell/src/main/ruby/shell/commands/drop_namespace.rb
* hbase-shell/src/main/ruby/shell/commands/update_config.rb
* hbase-shell/src/test/ruby/hbase/admin_test.rb
* hbase-shell/src/main/ruby/shell/commands/create_namespace.rb
* hbase-shell/src/main/ruby/shell/commands/remove_peer_tableCFs.rb
* hbase-shell/src/test/ruby/shell/shell_test.rb
* hbase-shell/src/main/ruby/shell/commands/add_labels.rb
* hbase-shell/src/main/ruby/shell/commands/list_procedures.rb
* hbase-shell/src/main/ruby/shell/commands/locate_region.rb
* hbase-shell/src/main/ruby/shell/commands/drop.rb
* hbase-shell/src/main/ruby/shell/commands/normalize.rb
* hbase-shell/src/main/ruby/shell/commands/scan.rb
* hbase-shell/src/main/ruby/shell/commands/describe_namespace.rb
* hbase-shell/src/main/ruby/shell/commands/close_region.rb
* hbase-shell/src/main/ruby/shell/commands/truncate_preserve.rb
* hbase-shell/src/main/ruby/shell/commands/wal_roll.rb
* hbase-shell/src/main/ruby/shell/commands/splitormerge_enabled.rb
* hbase-shell/src/main/ruby/shell/commands/catalogjanitor_enabled.rb
* hbase-shell/src/main/ruby/shell/commands/get_table.rb
* hbase-shell/src/main/ruby/hbase/table.rb
* hbase-shell/src/main/ruby/shell/commands/incr.rb
* hbase-shell/src/main/ruby/shell/commands/create.rb
* hbase-shell/src/main/ruby/shell/commands/delete_snapshot.rb
* hbase-shell/src/main/ruby/shell/commands/alter_namespace.rb
* hbase-shell/src/main/ruby/shell/commands/disable.rb
* hbase-shell/src/main/ruby/shell/commands/is_enabled.rb
* hbase-shell/src/main/ruby/shell/commands/list_table_snapshots.rb
* hbase-shell/src/main/ruby/shell/commands/get.rb
* hbase-shell/src/main/ruby/shell/commands/assign.rb
* hbase-shell/src/main/ruby/shell/commands/snapshot.rb
* hbase-shell/src/main/ruby/shell/commands/flush.rb
* hbase-shell/src/main/ruby/shell/commands/add_peer.rb
* hbase-shell/src/main/ruby/shell/commands/list_peer_configs.rb
* hbase-shell/src/main/ruby/shell/commands/enable.rb
* hbase-shell/src/main/ruby/shell/commands/alter_async.rb
* hbase-shell/src/main/ruby/shell/commands/revoke.rb
* hbase-shell/src/main/ruby/shell/commands/append_peer_tableCFs.rb
* hbase-shell/src/main/ruby/shell/commands/show_peer_tableCFs.rb
* hbase-shell/src/main/ruby/shell/commands/alter.rb
* hbase-shell/src/main/ruby/shell/commands/truncate.rb
* hbase-shell/src/main/ruby/shell/commands/list_labels.rb
* hbase-shell/src/main/ruby/shell/commands/normalizer_switch.rb
* hbase-shell/src/main/ruby/shell/commands/count.rb
* hbase-shell/src/main/ruby/shell/commands/abort_procedure.rb
* hbase-shell/src/main/ruby/shell/commands/balancer.rb
* hbase-shell/src/main/ruby/shell/commands/user_permission.rb
* hbase-shell/src/main/ruby/shell/commands/move.rb
* hbase-shell/src/main/ruby/shell/commands/deleteall.rb
* hbase-shell/src/main/ruby/shell/commands/compact.rb
* hbase-shell/src/main/ruby/shell/commands/compact_rs.rb
* hbase-shell/src/main/ruby/shell/commands/list_quotas.rb
* hbase-shell/src/main/ruby/shell/commands/update_peer_config.rb
* hbase-shell/src/main/ruby/shell/commands/enable_peer.rb
*
hbase-shell/src/test/java/org/apache/hadoop/hbase/client/TestReplicationShell.java
* hbase-shell/src/main/ruby/shell/commands/delete_table_snapshots.rb
* hbase-shell/src/main/ruby/shell/commands/balance_switch.rb
* hbase-shell/src/main/ruby/shell/commands/list_namespace_tables.rb
* hbase-shell/src/main/ruby/shell/commands/split.rb
* hbase-shell/src/main/ruby/shell/commands/put.rb
* hbase-shell/src/main/ruby/shell.rb
* hbase-shell/src/main/ruby/shell/commands/merge_region.rb
* hbase-shell/src/main/ruby/shell/commands/set_peer_tableCFs.rb
* hbase-shell/src/main/ruby/shell/commands/splitormerge_switch.rb
* hbase-shell/src/main/ruby/shell/commands/clone_snapshot.rb
* hbase-shell/src/main/ruby/shell/commands/major_compact.rb
* hbase-shell/src/main/ruby/shell/commands/normalizer_enabled.rb
* hbase-shell/src/main/ruby/shell/commands/describe.rb
* hbase-shell/src/main/ruby/shell/commands/balancer_enabled.rb
* hbase-shell/src/main/ruby/shell/commands/list_peers.rb
* hbase-shell/src/main/ruby/shell/commands/grant.rb
* hbase-shell/src/main/ruby/shell/commands/catalogjanitor_switch.rb
* hbase-shell/src/main/ruby/shell/commands/set_visibility.rb
* hbase-shell/src/main/ruby/shell/commands/trace.rb
* hbase-shell/src/main/ruby/shell/commands/catalogjanitor_run.rb
* hbase-shell/src/main/ruby/shell/commands/append.rb
* hbase-shell/src/main/ruby/shell/commands/enable_table_replication.rb
* hbase-shell/src/main/ruby/hbase/admin.rb
* hbase-shell/src/main/ruby/shell/formatter.rb
* hbase-shell/src/main/ruby/shell/commands/disable_table_replication.rb
* hbase-shell/src/main/ruby/shell/commands/restore_snapshot.rb
* hbase-shell/src/main/ruby/shell/commands/disable_peer.rb
* hbase-shell/src/main/ruby/shell/commands/remove_peer.rb
* hbase-shell/src/main/ruby/shell/commands/delete.rb
* hbase-shell/src/main/ruby/shell/commands/clear_auths.rb
* hbase-shell/src/main/ruby/shell/commands/unassign.rb
* hbase-shell/src/main/ruby/shell/commands/update_all_config.rb
* hbase-shell/src/main/ruby/shell/commands/show_filters.rb
* hbase-shell/src/main/ruby/shell/commands/set_auths.rb
* hbase-shell/src/main/ruby/shell/commands/exists.rb
* hbase-shell/src/main/ruby/shell/commands/list_snapshots.rb
* hbase-shell/src/main/ruby/shell/commands/is_disabled.rb
* hbase-shell/src/main/ruby/shell/commands/get_auths.rb
* hbase-shell/src/test/ruby/hbase/visibility_labels_admin_test.rb
* hbase-shell/src/main/ruby/shell/commands/list_namespace.rb
* hbase-shell/src/test/ruby/shell/formatter_test.rb
> Shell test changes. Use @shell.command instead directly calling functions in
> admin.rb and other libraries.
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-15965
> URL: https://issues.apache.org/jira/browse/HBASE-15965
> Project: HBase
> Issue Type: Bug
> Reporter: Appy
> Assignee: Appy
> Fix For: 2.0.0
>
> Attachments: HBASE-15965.master.001.patch,
> HBASE-15965.master.002.patch, HBASE-15965.master.003.patch
>
>
> Testing by executing a command will cover the exact path users will trigger,
> so its better then directly calling library functions in tests. Changing the
> tests to use @shell.command(:<command>, args) to execute them like it's a
> command coming from shell.
> Norm change:
> Commands should print the output user would like to see, but in the end,
> should also return the relevant value. This way:
> - Tests can use returned value to check that functionality works
> - Tests can capture stdout to assert particular kind of output user should
> see.
> - We do not print the return value in interactive mode and keep the output
> clean. See Shell.command() function.
> Bugs found due to this change:
> - Uncovered bug in major_compact.rb with this approach. It was calling
> admin.majorCompact() which doesn't exist but our tests didn't catch it since
> they directly tested admin.major_compact()
> - Enabled TestReplicationShell. If it's bad, flaky infra will take care of it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
