[ 
https://issues.apache.org/jira/browse/HBASE-14743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358025#comment-15358025
 ] 

Appy commented on HBASE-14743:
------------------------------

So here's what am seeing. 
1st screenshot: memory manager metrics which [~reidchan] is adding in this jira 
are getting populated.
2nd: they mysteriously get cleared.
But that's also happening to other metrics (3rd and 4th screenshots) so no 
point blocking this patch on it.
+1

*Screenshots*
Memory manager histogram working
!test2_1.png|height=400!

Memory manager histogram empty
!test2_2.png|height=400!

IPC metrics showing same behavior. It took 10+ tries to capture these because 
after executing Put from shell, by the time i switched to visualvm and 
refreshed, they'll be gone.
!test2_3.png|height=400!
!test2_4.png|height=400!

> Add metrics around HeapMemoryManager
> ------------------------------------
>
>                 Key: HBASE-14743
>                 URL: https://issues.apache.org/jira/browse/HBASE-14743
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Elliott Clark
>            Assignee: Reid Chan
>            Priority: Minor
>         Attachments: HBASE-14743.001.patch, HBASE-14743.002.patch, 
> HBASE-14743.003.patch, HBASE-14743.004.patch, HBASE-14743.005.patch, 
> HBASE-14743.006.patch, HBASE-14743.007.patch, HBASE-14743.008.patch, 
> HBASE-14743.009.patch, HBASE-14743.009.rw3.patch, HBASE-14743.009.v2.patch, 
> HBASE-14743.010.patch, Metrics snapshot 2016-6-30.png, Screen Shot 2016-06-16 
> at 5.39.13 PM.png, test2_1.png, test2_2.png, test2_3.png, test2_4.png
>
>
> it would be good to know how many invocations there have been.
> How many decided to expand memstore.
> How many decided to expand block cache.
> How many decided to do nothing.
> etc.
> When that's done use those metrics to clean up the tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to