[
https://issues.apache.org/jira/browse/HBASE-4853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu updated HBASE-4853:
--------------------------
Comment: was deleted
(was: By increasing timeout to 6 seconds (Pardon me, N), I wasn't able to
reproduce failure in TestGlobalMemStoreSize after 20 iterations:
{code}
Index: src/test/java/org/apache/hadoop/hbase/TestGlobalMemStoreSize.java
===================================================================
--- src/test/java/org/apache/hadoop/hbase/TestGlobalMemStoreSize.java
(revision 1205638)
+++ src/test/java/org/apache/hadoop/hbase/TestGlobalMemStoreSize.java
(working copy)
@@ -100,11 +100,12 @@
}
LOG.info("Post flush on " + server.getServerName());
long now = System.currentTimeMillis();
- long timeout = now + 3000;
+ long timeout = now + 6000;
while(server.getRegionServerAccounting().getGlobalMemstoreSize() != 0 &&
timeout < System.currentTimeMillis()) {
Threads.sleep(10);
}
+ LOG.info("About to check GlobalMemstoreSize");
assertEquals("Server=" + server.getServerName() + ", i=" + i++, 0,
server.getRegionServerAccounting().getGlobalMemstoreSize());
}
{code})
> HBASE-4789 does overzealous pruning of seqids
> ---------------------------------------------
>
> Key: HBASE-4853
> URL: https://issues.apache.org/jira/browse/HBASE-4853
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Priority: Critical
> Attachments: 4853--no-prefix.txt, 4853-trunk.txt, 4853-v4.txt,
> 4853-v5.txt, 4853-v6.txt, 4853.txt
>
>
> Working w/ J-D on failing replication test turned up hole in seqids made by
> the patch over in hbase-4789. With this patch in place we see lots of
> instances of the suspicious: 'Last sequenceid written is empty. Deleting all
> old hlogs'
> At a minimum, these lines need removing:
> {code}
> diff --git a/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
> b/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
> index 623edbe..a0bbe01 100644
> --- a/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
> +++ b/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java
> @@ -1359,11 +1359,6 @@ public class HLog implements Syncable {
> // Cleaning up of lastSeqWritten is in the finally clause because we
> // don't want to confuse getOldestOutstandingSeqNum()
> this.lastSeqWritten.remove(getSnapshotName(encodedRegionName));
> - Long l = this.lastSeqWritten.remove(encodedRegionName);
> - if (l != null) {
> - LOG.warn("Why is there a raw encodedRegionName in lastSeqWritten?
> name=" +
> - Bytes.toString(encodedRegionName) + ", seqid=" + l);
> - }
> this.cacheFlushLock.unlock();
> }
> }
> {code}
> ... but above is no good w/o figuring why WALs are not being rotated off.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
