[ 
https://issues.apache.org/jira/browse/HBASE-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362806#comment-15362806
 ] 

Ted Yu commented on HBASE-16157:
--------------------------------

+1 on v4.

> The incorrect block cache count and size are caused by removing duplicate 
> block key in the LruBlockCache
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16157
>                 URL: https://issues.apache.org/jira/browse/HBASE-16157
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Trivial
>         Attachments: HBASE-16157-v1.patch, HBASE-16157-v2.patch, 
> HBASE-16157-v3.patch, HBASE-16157-v4.patch
>
>
> {code:title=LruBlockCache.java|borderStyle=solid}
> // Check return value from the Map#remove before updating the metrics
>   protected long evictBlock(LruCachedBlock block, boolean 
> evictedByEvictionProcess) {
>     map.remove(block.getCacheKey());
>     updateSizeMetrics(block, true);
> ...
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to