[ 
https://issues.apache.org/jira/browse/HBASE-15682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368559#comment-15368559
 ] 

Ted Yu commented on HBASE-15682:
--------------------------------

{code}
+    while (counter++ < 2) {
...
+        if(counter == 2){
{code}
Can you define a constant prior to the loop and reference the constant ?

> HBase Backup Phase 3: Possible data loss during incremental WAL files copy
> --------------------------------------------------------------------------
>
>                 Key: HBASE-15682
>                 URL: https://issues.apache.org/jira/browse/HBASE-15682
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>              Labels: backup
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15682-v2.patch, HBASE-15682-v3.patch
>
>
> We collect list of files in WAL and oldWALs directory and launch DistCp job. 
> Some files can be moved from WALs to oldWALs  directory by RS during job's 
> run, what can result in potential data loss.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to