[
https://issues.apache.org/jira/browse/HBASE-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15370320#comment-15370320
]
Yu Li commented on HBASE-16194:
-------------------------------
bq. This should be applicable in 0.98+ all branches
Agree, and have prepared commits for all branch-1+ (waiting for HadoopQA), will
prepare a patch for 0.98 later. [~apurtell] [~ndimiduk] [~busbey] and
[~mantonov], please let me know if you have any concern to push the patch here
into relative branch, thanks.
bq. useMSLAB... Better name?
Have added below comments for the parameter in {{internalAdd}}:
{noformat}
+ * @param toAdd the cell to add
+ * @param useMSLAB whether using MSLAB
+ * @return the heap size change in bytes
{noformat}
So maybe we should change the comment to "whether to use MSLAB for the cell"?
Since the patch already gone into master branch, maybe an addendum here?
> Should count in MSLAB chunk allocation into heap size change when adding
> duplicate cells
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-16194
> URL: https://issues.apache.org/jira/browse/HBASE-16194
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 1.2.1, 1.1.5, 0.98.20
> Reporter: Yu Li
> Assignee: Yu Li
> Attachments: HBASE-16194.branch-1.patch, HBASE-16194.branch-1.patch,
> HBASE-16194.patch, HBASE-16194_v2.patch
>
>
> See more details about problem description and analysis in HBASE-16193
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
