[
https://issues.apache.org/jira/browse/HBASE-16081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372023#comment-15372023
]
Mikhail Antonov commented on HBASE-16081:
-----------------------------------------
Pushed to master, branch-1 and branch-1.3. Thanks for the patch! Test
failures appear to be unrelated, but will watch for the builds on stable
branches.
cc [~busbey]
> Replication remove_peer gets stuck and blocks WAL rolling
> ---------------------------------------------------------
>
> Key: HBASE-16081
> URL: https://issues.apache.org/jira/browse/HBASE-16081
> Project: HBase
> Issue Type: Bug
> Components: regionserver, Replication
> Affects Versions: 1.3.0
> Reporter: Ashu Pachauri
> Assignee: Joseph
> Priority: Blocker
> Attachments: HBASE-16081-v2.patch, HBASE-16081-v3.patch,
> HBASE-16081-v4.patch, HBASE-16081-v5.patch, HBASE-16081-v6.patch,
> HBASE-16081.patch
>
>
> We use a blocking take from CompletionService in
> HBaseInterClusterReplicationEndpoint. When we remove a peer, we try to shut
> down all threads gracefully. But, under certain race condition, the
> underlying executor gets shutdown and the CompletionService#take will block
> forever, which means the remove_peer call will never gracefully finish.
> Since ReplicationSourceManager#removePeer and
> ReplicationSourceManager#recordLog lock on the same object, we are not able
> to roll WALs in such a situation and will end up with gigantic WALs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
