[ https://issues.apache.org/jira/browse/HBASE-16243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383291#comment-15383291 ]
Ted Yu commented on HBASE-16243: -------------------------------- Thanks for the reminder. This issue was discovered when producing mega patch based in HBASE-7912 branch. Looks like there is no need to change the Admin API signature in master branch. Let me re-work the related part in mega patch. > Admin#takeSnapshotAsync should not expose Protos as the return type > ------------------------------------------------------------------- > > Key: HBASE-16243 > URL: https://issues.apache.org/jira/browse/HBASE-16243 > Project: HBase > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Labels: backup > Attachments: 16243.v1.txt > > > In HBASE-7912 branch, Admin#takeSnapshotAsync would trigger the following > assertion: > {code} > 2016-07-18 14:53:56,908 INFO [main] > hbase.TestInterfaceAudienceAnnotations(340): These are the methods that have > Protos as the return type > 2016-07-18 14:53:56,909 INFO [main] > hbase.TestInterfaceAudienceAnnotations(342): > org.apache.hadoop.hbase.client.Admin takeSnapshotAsync > org.apache.hadoop.hbase.protobuf.generated.MasterProtos$SnapshotResponse > {code} > Admin#takeSnapshotAsync should not expose Protos as the return type -- This message was sent by Atlassian JIRA (v6.3.4#6332)