[
https://issues.apache.org/jira/browse/HBASE-14123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15385232#comment-15385232
]
Hadoop QA commented on HBASE-14123:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} patch {color} | {color:blue} 0m 2s
{color} | {color:blue} The patch file was not named according to hbase's naming
conventions. Please see
https://yetus.apache.org/documentation/0.2.1/precommit-patchnames for
instructions. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 43 new or modified test
files. {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 8s
{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m
55s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 21s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 53s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 11m
29s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
44s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m
26s {color} | {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped branch modules with no Java source: . {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 5m
17s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 2s
{color} | {color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 38s
{color} | {color:green} master passed with JDK v1.7.0_80 {color} |
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 9s
{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
35s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 30s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 4m 30s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m 30s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m 52s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} cc {color} | {color:green} 3m 52s
{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 13m 8s {color}
| {color:red} hbase-server-jdk1.7.0_80 with JDK v1.7.0_80 generated 2 new + 4
unchanged - 2 fixed = 6 total (was 6) {color} |
| {color:red}-1{color} | {color:red} javac {color} | {color:red} 13m 8s {color}
| {color:red} root-jdk1.7.0_80 with JDK v1.7.0_80 generated 2 new + 30
unchanged - 2 fixed = 32 total (was 32) {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m 52s
{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 11m
49s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 1m
45s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} shellcheck {color} | {color:green} 0m
4s {color} | {color:green} There were no new shellcheck issues. {color} |
| {color:green}+1{color} | {color:green} shelldocs {color} | {color:green} 0m
1s {color} | {color:green} There were no new shelldocs issues. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 1s
{color} | {color:red} The patch has 597 line(s) that end in whitespace. Use git
apply --whitespace=fix. {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 16s
{color} | {color:red} The patch has 1 line(s) with tabs. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 0s
{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
26m 28s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 2m
29s {color} | {color:green} the patch passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s
{color} | {color:blue} Skipped patch modules with no Java source: . {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 12s
{color} | {color:red} hbase-client generated 9 new + 0 unchanged - 0 fixed = 9
total (was 0) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 17s
{color} | {color:red} hbase-server generated 13 new + 0 unchanged - 0 fixed =
13 total (was 0) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 6m 19s
{color} | {color:red} hbase-client-jdk1.8.0 with JDK v1.8.0 generated 9 new +
13 unchanged - 0 fixed = 22 total (was 13) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 6m 19s
{color} | {color:red} hbase-server-jdk1.8.0 with JDK v1.8.0 generated 11 new +
1 unchanged - 0 fixed = 12 total (was 1) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 6m 19s
{color} | {color:red} root-jdk1.8.0 with JDK v1.8.0 generated 14 new + 19
unchanged - 0 fixed = 33 total (was 19) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 4m 1s
{color} | {color:green} the patch passed with JDK v1.8.0 {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 9m 56s
{color} | {color:red} hbase-client-jdk1.7.0_80 with JDK v1.7.0_80 generated 9
new + 13 unchanged - 0 fixed = 22 total (was 13) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 9m 56s
{color} | {color:red} hbase-server-jdk1.7.0_80 with JDK v1.7.0_80 generated 11
new + 1 unchanged - 0 fixed = 12 total (was 1) {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 9m 56s
{color} | {color:red} root-jdk1.7.0_80 with JDK v1.7.0_80 generated 14 new + 23
unchanged - 0 fixed = 37 total (was 23) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 3m 36s
{color} | {color:green} the patch passed with JDK v1.7.0_80 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 19s
{color} | {color:green} hbase-protocol in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 42s
{color} | {color:green} hbase-common in the patch passed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 57s
{color} | {color:green} hbase-client in the patch passed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 102m 11s
{color} | {color:red} hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 111m 0s {color}
| {color:red} root in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 1m
22s {color} | {color:green} Patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 329m 1s {color}
| {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-client |
| | org.apache.hadoop.hbase.backup.BackupInfo.compareTo(BackupInfo) invokes
inefficient new Long(String) constructor; use Long.valueOf(String) instead At
BackupInfo.java:constructor; use Long.valueOf(String) instead At
BackupInfo.java:[line 464] |
| | org.apache.hadoop.hbase.backup.BackupInfo defines compareTo(BackupInfo)
and uses Object.equals() At BackupInfo.java:Object.equals() At
BackupInfo.java:[lines 464-468] |
| | Class org.apache.hadoop.hbase.backup.BackupStatus defines non-transient
non-serializable instance field table In BackupStatus.java:instance field
table In BackupStatus.java |
| | Possible null pointer dereference of args in
org.apache.hadoop.hbase.backup.impl.BackupCommands$BackupSetCommand.processSetDescribe(String[])
Dereferenced at BackupCommands.java:args in
org.apache.hadoop.hbase.backup.impl.BackupCommands$BackupSetCommand.processSetDescribe(String[])
Dereferenced at BackupCommands.java:[line 478] |
| | Dead store to backupId in
org.apache.hadoop.hbase.backup.impl.BackupCommands$CancelCommand.execute() At
BackupCommands.java:org.apache.hadoop.hbase.backup.impl.BackupCommands$CancelCommand.execute()
At BackupCommands.java:[line 377] |
| | Possible null pointer dereference of BackupCommands$CancelCommand.cmdline
in org.apache.hadoop.hbase.backup.impl.BackupCommands$CancelCommand.execute()
Dereferenced at BackupCommands.java:BackupCommands$CancelCommand.cmdline in
org.apache.hadoop.hbase.backup.impl.BackupCommands$CancelCommand.execute()
Dereferenced at BackupCommands.java:[line 376] |
| | Possible null pointer dereference of
BackupCommands$ProgressCommand.cmdline in
org.apache.hadoop.hbase.backup.impl.BackupCommands$ProgressCommand.execute()
Dereferenced at BackupCommands.java:BackupCommands$ProgressCommand.cmdline in
org.apache.hadoop.hbase.backup.impl.BackupCommands$ProgressCommand.execute()
Dereferenced at BackupCommands.java:[line 311] |
| | Nullcheck of args at line 312 of value previously dereferenced in
org.apache.hadoop.hbase.backup.impl.BackupCommands$ProgressCommand.execute()
At BackupCommands.java:312 of value previously dereferenced in
org.apache.hadoop.hbase.backup.impl.BackupCommands$ProgressCommand.execute()
At BackupCommands.java:[line 312] |
| | Possible null pointer dereference of response in new
org.apache.hadoop.hbase.client.HBaseAdmin$TableBackupFuture(HBaseAdmin,
TableName, MasterProtos$BackupTablesResponse) Dereferenced at
HBaseAdmin.java:response in new
org.apache.hadoop.hbase.client.HBaseAdmin$TableBackupFuture(HBaseAdmin,
TableName, MasterProtos$BackupTablesResponse) Dereferenced at
HBaseAdmin.java:[line 1775] |
| FindBugs | module:hbase-server |
| |
org.apache.hadoop.hbase.backup.impl.BackupManifest.setIncrementalTimestampMap(BackupProtos$BackupManifest$Builder)
makes inefficient use of keySet iterator instead of entrySet iterator At
BackupManifest.java:keySet iterator instead of entrySet iterator At
BackupManifest.java:[line 514] |
| |
org.apache.hadoop.hbase.backup.impl.BackupManifest$BackupImage.compareTo(BackupManifest$BackupImage)
invokes inefficient new Long(String) constructor; use Long.valueOf(String)
instead At BackupManifest.java:constructor; use Long.valueOf(String) instead
At BackupManifest.java:[line 226] |
| | org.apache.hadoop.hbase.backup.impl.BackupManifest$BackupImage defines
compareTo(BackupManifest$BackupImage) and uses Object.equals() At
BackupManifest.java:Object.equals() At BackupManifest.java:[lines 224-228] |
| | Boxed value is unboxed and then immediately reboxed in
org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager.getLogFilesForNewBackup(HashMap,
HashMap, Configuration, String) At IncrementalBackupManager.java:then
immediately reboxed in
org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager.getLogFilesForNewBackup(HashMap,
HashMap, Configuration, String) At IncrementalBackupManager.java:[line 271] |
| | Boxing/unboxing to parse a primitive
org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager.getLogFilesForNewBackup(HashMap,
HashMap, Configuration, String) At
IncrementalBackupManager.java:org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager.getLogFilesForNewBackup(HashMap,
HashMap, Configuration, String) At IncrementalBackupManager.java:[line 301] |
| | Boxed value is unboxed and then immediately reboxed in
org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager$NewestLogFilter.accept(Path)
At IncrementalBackupManager.java:then immediately reboxed in
org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager$NewestLogFilter.accept(Path)
At IncrementalBackupManager.java:[line 347] |
| | Should
org.apache.hadoop.hbase.backup.impl.IncrementalBackupManager$NewestLogFilter be
a _static_ inner class? At IncrementalBackupManager.java:inner class? At
IncrementalBackupManager.java:[lines 326-350] |
| | Possible null pointer dereference of job in
org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyService.cancelCopyJob(String)
Dereferenced at MapReduceBackupCopyService.java:job in
org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyService.cancelCopyJob(String)
Dereferenced at MapReduceBackupCopyService.java:[line 328] |
| | Potentially ambiguous invocation of either an outer or inherited method
org.apache.hadoop.conf.Configured.getConf() in
org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyService$BackupDistCp.execute()
At MapReduceBackupCopyService.java:an outer or inherited method
org.apache.hadoop.conf.Configured.getConf() in
org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyService$BackupDistCp.execute()
At MapReduceBackupCopyService.java:[line 186] |
| | Should
org.apache.hadoop.hbase.backup.mapreduce.MapReduceBackupCopyService$SnapshotCopy
be a _static_ inner class? At MapReduceBackupCopyService.java:inner class?
At MapReduceBackupCopyService.java:[lines 109-116] |
| | Unread field:MapReduceBackupCopyService.java:[line 111] |
| |
org.apache.hadoop.hbase.backup.util.BackupServerUtil.getRSLogTimestampMins(HashMap)
makes inefficient use of keySet iterator instead of entrySet iterator At
BackupServerUtil.java:keySet iterator instead of entrySet iterator At
BackupServerUtil.java:[line 146] |
| | Call to org.apache.hadoop.hbase.TableName.equals(String) in
org.apache.hadoop.hbase.backup.util.RestoreServerUtil.restoreTableAndCreate(TableName,
TableName, Path, boolean, boolean) At RestoreServerUtil.java:TableName, Path,
boolean, boolean) At RestoreServerUtil.java:[line 279] |
| Failed junit tests | hadoop.hbase.regionserver.TestRegionServerMetrics |
| | hadoop.hbase.master.TestAssignmentListener |
| | hadoop.hbase.regionserver.TestRegionServerMetrics |
| | hadoop.hbase.master.TestAssignmentListener |
| Timed out junit tests |
org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents |
| | org.apache.hadoop.hbase.master.procedure.TestMasterProcedureEvents |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12818884/14123-master.v3.txt |
| JIRA Issue | HBASE-14123 |
| Optional Tests | asflicense shellcheck shelldocs javac javadoc unit
findbugs hadoopcheck hbaseanti checkstyle compile xml cc hbaseprotoc |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / 638ca24 |
| Default Java | 1.7.0_80 |
| Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0
/home/jenkins/jenkins-slave/tools/hudson.model.JDK/JDK_1.7_latest_:1.7.0_80 |
| shellcheck | v0.3.3 (This is an old version that has serious bugs. Consider
upgrading.) |
| findbugs | v3.0.0 |
| javac | hbase-server-jdk1.7.0_80:
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/diff-compile-javac-hbase-server-jdk1.7.0_80.txt
|
| javac | root-jdk1.7.0_80:
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/diff-compile-javac-root-jdk1.7.0_80.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/whitespace-eol.txt
|
| whitespace |
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/whitespace-tabs.txt
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/new-findbugs-hbase-client.html
|
| findbugs |
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/new-findbugs-hbase-server.html
|
| javadoc | hbase-client-jdk1.8.0:
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/diff-javadoc-javadoc-hbase-client-jdk1.8.0.txt
|
| javadoc | hbase-server-jdk1.8.0:
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.8.0.txt
|
| javadoc | root-jdk1.8.0:
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/diff-javadoc-javadoc-root-jdk1.8.0.txt
|
| javadoc | hbase-client-jdk1.7.0_80:
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/diff-javadoc-javadoc-hbase-client-jdk1.7.0_80.txt
|
| javadoc | hbase-server-jdk1.7.0_80:
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/diff-javadoc-javadoc-hbase-server-jdk1.7.0_80.txt
|
| javadoc | root-jdk1.7.0_80:
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/diff-javadoc-javadoc-root-jdk1.7.0_80.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/patch-unit-hbase-server.txt
|
| unit |
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/patch-unit-root.txt
|
| unit test logs |
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/patch-unit-hbase-server.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/artifact/patchprocess/patch-unit-root.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/testReport/ |
| modules | C: hbase-protocol hbase-common hbase-client hbase-server . U: . |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/2682/console |
| Powered by | Apache Yetus 0.2.1 http://yetus.apache.org |
This message was automatically generated.
> HBase Backup/Restore Phase 2
> ----------------------------
>
> Key: HBASE-14123
> URL: https://issues.apache.org/jira/browse/HBASE-14123
> Project: HBase
> Issue Type: Umbrella
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Attachments: 14123-master.v2.txt, 14123-master.v3.txt, 14123-v14.txt,
> HBASE-14123-for-7912-v1.patch, HBASE-14123-for-7912-v6.patch,
> HBASE-14123-v1.patch, HBASE-14123-v10.patch, HBASE-14123-v11.patch,
> HBASE-14123-v12.patch, HBASE-14123-v13.patch, HBASE-14123-v15.patch,
> HBASE-14123-v16.patch, HBASE-14123-v2.patch, HBASE-14123-v3.patch,
> HBASE-14123-v4.patch, HBASE-14123-v5.patch, HBASE-14123-v6.patch,
> HBASE-14123-v7.patch, HBASE-14123-v9.patch
>
>
> Phase 2 umbrella JIRA. See HBASE-7912 for design document and description.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
