[ 
https://issues.apache.org/jira/browse/HBASE-14921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393193#comment-15393193
 ] 

Anoop Sam John commented on HBASE-14921:
----------------------------------------

Ya [~anastas] the 2 points I raised are those..  I wanted to make sure those 
are highlighted early rather than saying it after..  And I dont mean they 
should be addressed in a single jira. Ya this is already big patch and no need 
to do more work again.. That is the common practice we follow.. When a comment 
needs more work, the developer can suggest doing it later as part of another 
jira and reviewers mostly agree. I am fine for that..  Sorry if I was not 
saying it explicitly.  It is a practice for us so I missed. Sorry.
It is your wish..  In this form also am ok to get that in.. We can always make 
things better after.
The cost of scan may be more when we have CellChunkMap.. In this flattened 
form, we get rid of Cell objects and again this Scan will make these objects 
over us.  With CellArrayMap the overhead might be from SQM and StoreScanner 
heap.  With CellChunkMap it is more.. That is why I raised it early.  Ya let us 
do that later also. Its ok.

> Memory optimizations
> --------------------
>
>                 Key: HBASE-14921
>                 URL: https://issues.apache.org/jira/browse/HBASE-14921
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Eshcar Hillel
>            Assignee: Anastasia Braginsky
>         Attachments: CellBlocksSegmentInMemStore.pdf, 
> CellBlocksSegmentinthecontextofMemStore(1).pdf, HBASE-14921-V01.patch, 
> HBASE-14921-V02.patch, HBASE-14921-V03.patch, HBASE-14921-V04-CA-V02.patch, 
> HBASE-14921-V04-CA.patch, HBASE-14921-V05-CAO.patch, 
> HBASE-14921-V06-CAO.patch, InitialCellArrayMapEvaluation.pdf, 
> IntroductiontoNewFlatandCompactMemStore.pdf
>
>
> Memory optimizations including compressed format representation and offheap 
> allocations



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to