[
https://issues.apache.org/jira/browse/HBASE-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393351#comment-15393351
]
ramkrishna.s.vasudevan commented on HBASE-16225:
------------------------------------------------
bq.And it is much easier to implement new stuffs on the refactored SQM than the
old big SQM. Thanks.
Yes. I think this refactoring is great.
bq.We should not pass delete marker to filter.
I agree to your point but one question (not gone thro the code closely). You
mean delete markers are now passed to filters (The per cell filter)?
bq.So I think if you want to deal with delete marker with coprocessor when
compaction, it is better to write a new scanner implementation
So this is for cases where there are special CPs written to deal with delete
markers in compaction? Or you mean in the current code? (sorry for not having
read the code for this case). Just asking.
bq.. Is it correct to check filter before check version? I think this could
also make the disappear cell appear again?
This has been the topic of discussion for a long time. What do you reckon? If
we change the behaviour some existing use cases built with filters may break.
> Refactor ScanQueryMatcher
> -------------------------
>
> Key: HBASE-16225
> URL: https://issues.apache.org/jira/browse/HBASE-16225
> Project: HBase
> Issue Type: Improvement
> Reporter: Duo Zhang
> Assignee: Duo Zhang
> Attachments: HBASE-16225-v1.patch, HBASE-16225-v2.patch,
> HBASE-16225.patch
>
>
> As said in HBASE-16223, the code of {{ScanQueryMatcher}} is too complicated.
> I suggest that we can abstract an interface and implement several sub classes
> which separate different logic into different implementations. For example,
> the requirements of compaction and user scan are different, now we also need
> to consider the logic of user scan even if we only want to add a logic for
> compaction. And at least, the raw scan does not need a query matcher... we
> can implement a dummy query matcher for it.
> Suggestions are welcomed. Thanks.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
