[ 
https://issues.apache.org/jira/browse/HBASE-16196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Mullins updated HBASE-16196:
---------------------------------
    Attachment: hbase-16196.v2.branch-1.patch

Agreed on testing {{region_mover.rb}}; I've included some changes in v2 that 
get it to run on my development machine, but I will test it manually on a 
distributed cluster as well.  I'll also make sure that the other Ruby scripts 
in bin/ work.

Attached an updated patch with the following changes that seem to satisfy the 
testsuite:
* The shell's exception handling has been updated to handle Ruby 2.1's addition 
of Exception#cause - this patch continues to throw a Ruby RuntimeError instead 
of walking the chain of .cause() to the native Java exception.
* {{Hbase::Admin#describe}} now checks the existence of a table like many other 
commands, in order to throw a Ruby exception rather than a Java native 
exception.  The test for Admin#describe now calls it with a non-existent but 
otherwise legal table name.  This was previous the only test using an illegal 
name (which results in a Java-native IllegalArgumentException instead).
* setLoadPaths() is now on the ScriptingContainer in JRuby.
* region_mover.rb is minimally changed due to {{require}} loading being 
slightly different.

> Update jruby to a newer version.
> --------------------------------
>
>                 Key: HBASE-16196
>                 URL: https://issues.apache.org/jira/browse/HBASE-16196
>             Project: HBase
>          Issue Type: Bug
>          Components: dependencies, shell
>            Reporter: Elliott Clark
>            Assignee: Matt Mullins
>            Priority: Critical
>             Fix For: 2.0.0, 1.4.0
>
>         Attachments: 0001-Update-to-JRuby-9.1.2.0-and-JLine-2.12.patch, 
> hbase-16196.branch-1.patch, hbase-16196.v2.branch-1.patch
>
>
> Ruby 1.8.7 is no longer maintained.
> The TTY library in the old jruby is bad. The newer one is less bad.
> Since this is only a dependency on the hbase-shell module and not on 
> hbase-client or hbase-server this should be a pretty simple thing that 
> doesn't have any backwards compat issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to