[
https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15405566#comment-15405566
]
Xiang Li commented on HBASE-14882:
----------------------------------
[~anoop.hbase], I am drafting the very first patch, something need to discuss
with you, as follow:
1. I plan to name the new implementation as "InputsImmutableCellForPut", and
put it as an internal protected class within Put class. Sounds good to you?
2. Regarding
{code}
/**
* See {@link #addColumn(byte[], byte[], byte[])}. This version expects
* that the underlying arrays won't change. It's intended
* for usage internal HBase to and for advanced client applications.
*/
public Put addImmutable(byte [] family, byte [] qualifier, byte [] value)
{code}
Do wee need the caller to guarantee value is also immutable as family and
qualifier? Can we keep a reference to value in the new implementation directly?
> Provide a Put API that adds the provided family, qualifier, value without
> copying
> ---------------------------------------------------------------------------------
>
> Key: HBASE-14882
> URL: https://issues.apache.org/jira/browse/HBASE-14882
> Project: HBase
> Issue Type: Improvement
> Reporter: Jerry He
> Assignee: Xiang Li
>
> In the Put API, we have addImmutable()
> {code}
> /**
> * See {@link #addColumn(byte[], byte[], byte[])}. This version expects
> * that the underlying arrays won't change. It's intended
> * for usage internal HBase to and for advanced client applications.
> */
> public Put addImmutable(byte [] family, byte [] qualifier, byte [] value)
> {code}
> But in the implementation the row, family. qualifier and value are still
> being copied locally to create kv.
> Hopefully we should provide an API that truely uses immutable family,
> qualifier and value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
