[
https://issues.apache.org/jira/browse/HBASE-16224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15407015#comment-15407015
]
Heng Chen edited comment on HBASE-16224 at 8/4/16 2:43 AM:
-----------------------------------------------------------
{code}
+ private boolean addNewOne = false;
{code}
{{addNewOne}} in TaskSizeChecker seems useless, if we want to add one request
at least, just return {{ReturnCode.INCLUDE}}.
Please add some comments about isFull in TaskSizeChecker, and the param seems
not be used in the method.
{code}
boolean isFull(final long requestSize)
{code}
{code}
private boolean isFull = false;
{code}
Why we need it? ReturnCode.SKIP is enough for judgement in
TaskSizeChecker.visit?
was (Author: chenheng):
{code}
+ private boolean addNewOne = false;
{code}
{{addNewOne}} in TaskSizeChecker seems useless, if we want to add one request
at least, just return {{ReturnCode.INCLUDE}}.
Please add some comments about isFull in TaskSizeChecker, and the param seems
not be used in the method.
{code}
boolean isFull(final long requestSize)
{code}
> Reduce the number of RPCs for the large PUTs
> --------------------------------------------
>
> Key: HBASE-16224
> URL: https://issues.apache.org/jira/browse/HBASE-16224
> Project: HBase
> Issue Type: Improvement
> Reporter: ChiaPing Tsai
> Assignee: ChiaPing Tsai
> Priority: Minor
> Attachments: HBASE-16224-v1.patch, HBASE-16224-v2.patch,
> HBASE-16224-v3.patch, HBASE-16224-v4.patch, HBASE-16224-v5.patch,
> HBASE-16224-v6.patch, HBASE-16224-v7.patch, HBASE-16224-v8.patch,
> experiment.xlsx
>
>
> This patch is proposed to reduce the number of RPC for the large PUTs
> The number and data size of write thread(SingleServerRequestRunnable) is a
> result of three main factors：
> 1) The flush size taken by BufferedMutatorImpl#backgroundFlushCommits
> 2) The limit of task number
> 3) ClientBackoffPolicy
> A lot of threads created with less MUTATIONs is a result of two reason: 1)
> many regions of target table are in different server. 2) flush size in step
> one is summed by “all” server rather than “individual” server
> This patch removes the limit of flush size in step one and add maximum size
> to submit for each server in the AsyncProcess
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
