[ 
https://issues.apache.org/jira/browse/HBASE-16198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408066#comment-15408066
 ] 

Ted Yu commented on HBASE-16198:
--------------------------------

{code}
+  private static final String HISTORY_CMD_USAGE = "Usage: hbase backup history 
[-path BACKUP_ROOT] [-n N] [-t table]\n"
{code}
Wrap long line.
{code}
+    private Path getBackupRootPath() {
+      String value = cmdline.getOptionValue("t");
{code}
Is the above right ? "t" is for table name, right ?

Is there any change in BackupManifest.java since it is moved to hbase-client 
package.
{code}
+  public static List<BackupInfo> getHistory(Configuration conn, Path 
backupRootPath) throws IOException {
{code}
Please name Configuration parameter conf (or similar).
{code}
+        } else {
+          //TODO
+          return -1;
{code}
What's the plan for the above case ?
{code}
+      List<BackupInfo> history = table.getBackupHistoryForTable(name);
{code}
Is it possible to pass n into the above method so that fewer rows are retrieved 
from backup table ?


> Enhance backup history command
> ------------------------------
>
>                 Key: HBASE-16198
>                 URL: https://issues.apache.org/jira/browse/HBASE-16198
>             Project: HBase
>          Issue Type: New Feature
>    Affects Versions: 2.0.0
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16198-v1.patch, HBASE-16198-v2.patch, 
> HBASE-16198-v3.patch
>
>
> We need history per table and ability to run command on a fully disabled 
> cluster (using info from backup file system only).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to