[
https://issues.apache.org/jira/browse/HBASE-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15408908#comment-15408908
]
Anoop Sam John commented on HBASE-16310:
----------------------------------------
So here the contract is, if a Filter implement filterAllRemaining(),
filterRowKey(Cell) also have to consider the same condition at first. If
filterAllRemaining() return true, filterRowKey(Cell) must return true. It
would be better to add this contract very clear in Filter javadoc. (Around
these methods) - This is some thing like a Object equal() hashCode() contract.
Addition in FilterWrapper would be enough to get all well as we will wrap
filters in read with this wrapper always. But better handle in all of HBase
Filters as it is our contract. So this will go in 2.0 only?
ColumnCountGetFilter - Why not changed filterRowKey(byte[], int, int)?
The patch is not in line with what we say in the title of the Jira. Pls update.
This patch is abt making the Filter contract around 2 methods.
Overall looks good.
> Revisit the logic of filterRowKey for FilterList
> ------------------------------------------------
>
> Key: HBASE-16310
> URL: https://issues.apache.org/jira/browse/HBASE-16310
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.0.3, 1.1.5, 1.2.2
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0, 1.3.0
>
> Attachments: HBASE-16310.patch
>
>
> Based on HBASE-16926 it was observed that filterRowKey() API behaviour for
> FilterList and a standalone filter should be made consistent. This JIRA is to
> track down the changes and ensure 1.3+ on wards we have consistent behaviour.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
