[
https://issues.apache.org/jira/browse/HBASE-8386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410251#comment-15410251
]
Hudson commented on HBASE-8386:
-------------------------------
SUCCESS: Integrated in HBase-1.3-IT #782 (See
[https://builds.apache.org/job/HBase-1.3-IT/782/])
HBASE-8386 deprecate TableMapReduce.addDependencyJars(Configuration, (busbey:
rev 3175d8073071854b3940c4dc547fbe9edaa234bf)
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestTableSnapshotInputFormat.java
*
hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestLoadAndVerify.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/TableMapReduceUtil.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/ImportTsv.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/mapred/TestTableSnapshotInputFormat.java
* src/main/asciidoc/_chapters/mapreduce.adoc
*
hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableMapReduceUtil.java
*
hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestWithCellVisibilityLoadAndVerify.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/PerformanceEvaluation.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java
*
hbase-it/src/test/java/org/apache/hadoop/hbase/test/IntegrationTestBigLinkedList.java
> deprecate TableMapReduce.addDependencyJars(Configuration, class<?> ...)
> -----------------------------------------------------------------------
>
> Key: HBASE-8386
> URL: https://issues.apache.org/jira/browse/HBASE-8386
> Project: HBase
> Issue Type: Improvement
> Components: mapreduce
> Reporter: Nick Dimiduk
> Assignee: Sean Busbey
> Fix For: 2.0.0, 1.3.0, 1.4.0
>
> Attachments: HBASE-8386.1.patch
>
>
> We expose two public static methods names {{addDependencyJars}}. One of them,
> {{void addDependencyJars(Job}}, is very helpful -- goes out of its way to
> detect job dependencies as well as shipping all the necessary HBase
> dependencies. The other is shfty and nefarious, {{void
> addDependencyJars(Configuration, Class<?>...)}} -- it only adds exactly what
> the user requests, forcing them to resolve dependencies themselves and giving
> a false sense of security. We should deprecate the latter throw a big giant
> warning when people use that one. The handy functionality of providing help
> when our heuristics fail can be added via a new method signature, something
> like {{void addDependencyJars(Job, Class<?> ...}}. This method would do
> everything {{void addDependencyJars(Job}} does, plus let the user specify
> arbitrary additional classes. That way HBase still can help the user, but
> also gives them super-powers to compensate for when our heuristics fail.
> For reference, this appears to be the reason why HBase + Pig doesn't really
> work out of the box. See
> [HBaseStorage.java|https://github.com/apache/pig/blob/trunk/src/org/apache/pig/backend/hadoop/hbase/HBaseStorage.java#L730]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
