[
https://issues.apache.org/jira/browse/HBASE-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410737#comment-15410737
]
stack commented on HBASE-16359:
-------------------------------
Commits that have this as commit message "4b3e45f HBASE-16359 Addendum moves
null checking as suggested by Heng" are absent the JIRA subject. They mess up
our commit history as these commits are not like the others. Please add
comments like 'Addendum moves null checking as suggested by Heng' after the
full JIRA subject 'HBASE-16359 NullPointerException in
RSRpcServices.openRegion()' when you commit. Better still, use the
./dev-support/submit-patch.py script with description of what is being changed.
Doing otherwise makes it tougher on those who are trying to follow along.
> NullPointerException in RSRpcServices.openRegion()
> --------------------------------------------------
>
> Key: HBASE-16359
> URL: https://issues.apache.org/jira/browse/HBASE-16359
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.1.2
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 2.0.0, 1.4.0
>
> Attachments: 16359.addendum, 16359.v2.txt
>
>
> I was investigating why some region failed to move out of transition within
> timeout 120000ms and found the following in region server log:
> {code}
> 2016-08-04 09:19:52,616 INFO
> [B.priority.fifo.QRpcServer.handler=12,queue=0,port=16020]
> regionserver.RSRpcServices: Open hbck_table_772674,,1470302211047.
> da859880bb51bc0fd25979798a96c444.
> 2016-08-04 09:19:52,620 ERROR
> [B.priority.fifo.QRpcServer.handler=12,queue=0,port=16020] ipc.RpcServer:
> Unexpected throwable object
> java.lang.NullPointerException
> at
> org.apache.hadoop.hbase.regionserver.RSRpcServices.openRegion(RSRpcServices.java:1530)
> at
> org.apache.hadoop.hbase.protobuf.generated.AdminProtos$AdminService$2.callBlockingMethod(AdminProtos.java:22737)
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2127)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:107)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:133)
> {code}
> Here is related code - NPE was thrown from the last line:
> {code}
> htd = htds.get(region.getTable());
> if (htd == null) {
> htd = regionServer.tableDescriptors.get(region.getTable());
> htds.put(region.getTable(), htd);
> }
> ...
> if (region.isMetaRegion()) {
> regionServer.service.submit(new OpenMetaHandler(
> regionServer, regionServer, region, htd, masterSystemTime,
> coordination, ord));
> } else {
>
> regionServer.updateRegionFavoredNodesMapping(region.getEncodedName(),
> regionOpenInfo.getFavoredNodesList());
> if (htd.getPriority() >= HConstants.ADMIN_QOS ||
> region.getTable().isSystemTable()) {
> {code}
> region.getTable() shouldn't be null since it is called via
> htds.get(region.getTable()) unconditionally.
> It seems htd was null.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
