[ 
https://issues.apache.org/jira/browse/HBASE-16197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413884#comment-15413884
 ] 

Ted Yu commented on HBASE-16197:
--------------------------------

{code}
+   * @param backupId - backup id
+   * @return total number of deleted backup images
+   * @throws IOException
+   */
+  private int deleteBackup(String backupId, BackupSystemTable table) throws 
IOException {
{code}
Add @param for parameter table.
{code}
+        // Backup type: FULL or INCREMENTAL
+        // Last backup session for T: YES or NO
+        // ALgorithm:
{code}
The above can go into javadoc for method.

Patch is slightly out of sync with HBASE-7912 branch.

> Enchance backup delete command
> ------------------------------
>
>                 Key: HBASE-16197
>                 URL: https://issues.apache.org/jira/browse/HBASE-16197
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Vladimir Rodionov
>            Assignee: Vladimir Rodionov
>             Fix For: 2.0.0
>
>         Attachments: HBASE-16197-v1.patch, HBASE-16197-v2.patch
>
>
> Currently, backup delete command deletes only physical files/directories in 
> backup destination. It does not update backup system table (incremental 
> backup table set) and it does not delete related backup images (previous 
> ones), thus creating a hole in dependency chain. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to