[ 
https://issues.apache.org/jira/browse/HBASE-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421817#comment-15421817
 ] 

Stephen Yuan Jiang commented on HBASE-16418:
--------------------------------------------

Agree, the wait in IntegrationTestBulkLoad is unnecessary.  The patch to remove 
unnecessary sleep looks good.

Also in master branch, the Admin.modifyTable returns Future, we could use get() 
to simplify the logic in HBaseTestingUtility.modifyTableSync().  


> Reduce duration of sleep waiting for region reopen in 
> IntegrationTestBulkLoad#installSlowingCoproc()
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-16418
>                 URL: https://issues.apache.org/jira/browse/HBASE-16418
>             Project: HBase
>          Issue Type: Test
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: 16418.v1.txt
>
>
> Currently we have the following code:
> {code}
>     desc.addCoprocessor(SlowMeCoproScanOperations.class.getName());
>     HBaseTestingUtility.modifyTableSync(admin, desc);
>     //sleep for sometime. Hope is that the regions are closed/opened before
>     //the sleep returns. TODO: do this better
>     Thread.sleep(30000);
> {code}
> Instead of sleeping for fixed duration, we should detect when the regions 
> have reopened with custom Coprocessor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to