[ https://issues.apache.org/jira/browse/HBASE-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ChiaPing Tsai updated HBASE-16346: ---------------------------------- Attachment: HBASE-16346.v0.patch TestReplicationKillSlaveRS is passed locally > The addColumn() method of INCREMENT does not accept null qualifier > ------------------------------------------------------------------ > > Key: HBASE-16346 > URL: https://issues.apache.org/jira/browse/HBASE-16346 > Project: HBase > Issue Type: Bug > Reporter: ChiaPing Tsai > Assignee: ChiaPing Tsai > Priority: Trivial > Attachments: HBASE-16346-v0.txt, HBASE-16346.v0.patch > > > {code:title=Increment.java|borderStyle=solid} > // Is it necessary to prevent the null qualifier > public Increment addColumn(byte [] family, byte [] qualifier, long amount) { > if (family == null) { > throw new IllegalArgumentException("family cannot be null"); > } > if (qualifier == null) { > throw new IllegalArgumentException("qualifier cannot be null"); > } > List<Cell> list = getCellList(family); > KeyValue kv = createPutKeyValue(family, qualifier, ts, > Bytes.toBytes(amount)); > list.add(kv); > familyMap.put(CellUtil.cloneFamily(kv), list); > return this; > } > {code} > I use the add(Cell) method to add the cell with null qualifier and it works > fine. > It seems to me that the check should be removed > any command? thanks -- This message was sent by Atlassian JIRA (v6.3.4#6332)