[
https://issues.apache.org/jira/browse/HBASE-16450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428372#comment-15428372
]
stack commented on HBASE-16450:
-------------------------------
Looks nice. You have a picture of what it looks like when you do the dump call?
What you think of the findbugs complaints [~esteban]?
These have to be static?
+ private static final Log LOG =
LogFactory.getLog(DumpReplicationQueues.class.getName());
+
+ private static Configuration conf;
+
+ private static ReplicationAdmin replicationAdmin;
+ private static String replicationZNode;
+ private static ClusterConnection connection;
+ private static Path oldLogDir, logDir, rootDir;
+ private static FileSystem fs;
Put this in a finally block?
+ zkw.close();
... doesn't matter much since jvm will be exiting...
The core of dumpQueuesOrFix could be moved to a new method where you pass in
the loop item?
But no biggie.
Looks great. We need this kind of tooling bad. Thanks [~esteban]
> Shell tool to dump replication queues
> --------------------------------------
>
> Key: HBASE-16450
> URL: https://issues.apache.org/jira/browse/HBASE-16450
> Project: HBase
> Issue Type: Improvement
> Components: Operability, Replication
> Affects Versions: 2.0.0, 1.3.0, 1.1.5, 1.2.2
> Reporter: Esteban Gutierrez
> Assignee: Esteban Gutierrez
> Attachments: HBASE-16450.branch-1.001.patch,
> HBASE-16450.master.001.patch
>
>
> Currently there is no way to dump list of the configured queues and the
> replication queues when replication is enabled. Unfortunately the HBase
> master only offers an option to dump the whole content of the znodes but not
> details on the queues being processed on each RS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
