[
https://issues.apache.org/jira/browse/HBASE-16446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430198#comment-15430198
]
Ashish Singhi commented on HBASE-16446:
---------------------------------------
bq. If we keep it same with append_peer_tableCFs, the empty cf set in
remove_peer_tableCFs should means remove all cfs of this table too.
Yes, from the code also it looks like intention was that only, but then it
missed empty check.
{code}
List<String> cfs = preTableCfs.get(table);
if (cfs == null && removeCfs == null) {
preTableCfs.remove(table);
{code}
Needs similar handling as append_peer_tableCFs command.
> append_peer_tableCFs failed when there already have this table's partial cfs
> in the peer
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-16446
> URL: https://issues.apache.org/jira/browse/HBASE-16446
> Project: HBase
> Issue Type: Bug
> Components: Replication
> Affects Versions: 2.0.0
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Priority: Minor
> Attachments: HBASE-16446.patch
>
>
> {code}
> hbase(main):011:0> list_peers
> PEER_ID CLUSTER_KEY STATE TABLE_CFS PROTOCOL BANDWIDTH
> 20 hbase://c3tst-pressure98 ENABLED default.test_replication:A NATIVE 0
> 1 row(s) in 0.0080 seconds
> hbase(main):012:0> append_peer_tableCFs '20', {"test_replication" => []}
> 0 row(s) in 0.0060 seconds
> hbase(main):013:0> list_peers
> PEER_ID CLUSTER_KEY STATE TABLE_CFS PROTOCOL BANDWIDTH
> 20 hbase://c3tst-pressure98 ENABLED default.test_replication:A NATIVE 0
> 1 row(s) in 0.0030 seconds
> {code}
> "test_replication" => [] means replication all cf of this table,so the result
> is not right. It should not just contain cf A after append_peer_tableCFs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
