[
https://issues.apache.org/jira/browse/HBASE-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160219#comment-13160219
]
Hadoop QA commented on HBASE-4903:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12505635/HBASE-4903.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -162 warning
messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 67 new Findbugs (version
1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestRollingRestart
org.apache.hadoop.hbase.master.TestRestartCluster
org.apache.hadoop.hbase.master.TestDistributedLogSplitting
org.apache.hadoop.hbase.master.TestHMasterRPCException
org.apache.hadoop.hbase.mapreduce.TestTimeRangeMapRed
org.apache.hadoop.hbase.master.TestMaster
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesSplitRecovery
org.apache.hadoop.hbase.master.TestMasterRestartAfterDisablingTable
org.apache.hadoop.hbase.mapreduce.TestTableInputFormatScan
org.apache.hadoop.hbase.master.TestZKBasedOpenCloseRegion
org.apache.hadoop.hbase.TestFullLogReconstruction
org.apache.hadoop.hbase.avro.TestAvroServer
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles
org.apache.hadoop.hbase.master.TestMasterFailover
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.master.TestMasterTransitions
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapreduce.TestTableMapReduce
org.apache.hadoop.hbase.master.TestOpenedRegionHandler
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/408//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/408//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/408//console
This message is automatically generated.
> Return a result from RegionObserver.preIncrement()
> --------------------------------------------------
>
> Key: HBASE-4903
> URL: https://issues.apache.org/jira/browse/HBASE-4903
> Project: HBase
> Issue Type: Improvement
> Reporter: Daniel Gómez Ferro
> Attachments: HBASE-4903.patch, HBASE-4903.patch
>
>
> The only way to return a result from RegionObserver.preIncrement() is to use
> Result.readFields() after serializing the correct result.
> This can be fixed either returning a Result object from that function or
> adding setters to Result. Another option is to modify the parameters and
> receive a List<KeyValue> as preGet() does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
