[
https://issues.apache.org/jira/browse/HBASE-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guangxu Cheng updated HBASE-16456:
----------------------------------
Status: Patch Available (was: Open)
> Fix findbugs warnings in hbase-rsgroup module
> ---------------------------------------------
>
> Key: HBASE-16456
> URL: https://issues.apache.org/jira/browse/HBASE-16456
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
> Attachments: HBASE-16456-v1.patch, findbugs-rsgroup.html
>
>
> https://builds.apache.org/job/PreCommit-HBASE-Build/3161/artifact/patchprocess/branch-findbugs-hbase-rsgroup-warnings.html
> :
> Multithreaded correctness Warnings
> Code Warning
> SC new
> org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl(MasterServices)
> invokes
> org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.start()
> SWL org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer.moveServers(Set,
> String) calls Thread.sleep() with a lock held
> Performance Warnings
> Code Warning
> WMI
> org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.correctAssignments(Map)
> makes inefficient use of keySet iterator instead of entrySet iterator
> WMI
> org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer.getMisplacedRegions(Map)
> makes inefficient use of keySet iterator instead of entrySet iterator
> Dodgy code Warnings
> Code Warning
> REC Exception is caught when Exception is not thrown in
> org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl$RSGroupStartupWorker.waitForGroupTableOnline()
> ST Write to static field
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.groupInfoManager from
> instance method
> org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.start(CoprocessorEnvironment)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
