[
https://issues.apache.org/jira/browse/HBASE-16486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15435264#comment-15435264
]
Stephen Yuan Jiang commented on HBASE-16486:
--------------------------------------------
>From offline discussion with [~mbertozzi]: "I was talked a bit with [~stack]
>about this to get his opinion.
aside from the fact that the one liner master.createTable() looks better than
the two lines to create the regions and call new CreateTableProcedure().
HMaster should be the non RPC way to do stuff.. so master.createTable() should
be a "good" way to call tables.. but there are a bunch of problems like the
checkInitialized() that we don't want to wait on especially for sys tables. so
one option is to create a master.createSysTable()..."
Based on this feedback, I unified all system table creation under a new
master.createSystemTable() API in the attach V3 patch.
> ACL/labels system table creation should call CreateTableProcedure directly
> ---------------------------------------------------------------------------
>
> Key: HBASE-16486
> URL: https://issues.apache.org/jira/browse/HBASE-16486
> Project: HBase
> Issue Type: Improvement
> Components: proc-v2
> Affects Versions: 2.0.0, 1.4.0
> Reporter: Stephen Yuan Jiang
> Assignee: Stephen Yuan Jiang
> Priority: Minor
> Attachments: HBASE-16486.v1-master.patch,
> HBASE-16486.v2-master.patch, HBASE-16486.v3-master.patch
>
>
> All other system tables (namespace, quota, rsgroups) calls
> CreateTableProcedure directly; only ACL and labels system tables calls
> HMaster.createTable(), which will go through preCreateTable and
> postCreateTable Coprocessor. This is unnecessary and we should make the ACL
> system table creation the same as other system tables.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
