[ https://issues.apache.org/jira/browse/HBASE-16448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437267#comment-15437267 ]
Hudson commented on HBASE-16448: -------------------------------- FAILURE: Integrated in Jenkins build HBase-0.98-on-Hadoop-1.1 #1265 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1265/]) Amend HBASE-16448 Custom metrics for custom replication endpoints (apurtell: rev e78008700bcf30443cdd94b206575d8bb2ce31f8) * (edit) hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationSourceSourceImpl.java * (edit) hbase-hadoop1-compat/src/main/java/org/apache/hadoop/hbase/replication/regionserver/MetricsReplicationGlobalSourceSource.java > Custom metrics for custom replication endpoints > ----------------------------------------------- > > Key: HBASE-16448 > URL: https://issues.apache.org/jira/browse/HBASE-16448 > Project: HBase > Issue Type: Improvement > Components: Replication > Affects Versions: 2.0.0, 1.2.2, 0.98.21 > Reporter: Geoffrey Jacoby > Assignee: Geoffrey Jacoby > Fix For: 2.0.0, 1.4.0, 0.98.22 > > Attachments: HBASE-16448-0.98.patch, HBASE-16448-branch-1.patch, > HBASE-16448.patch > > > ReplicationEndpoints contain a MetricsSource class that can update a fixed > set of key replication metrics. It does not, however, allow a developer > implementing a custom ReplicationEndpoint to create/update custom metrics > unique to the new endpoint's use case. > As it turns out, MetricsSource wraps a class, which in turn wraps a class, > that implements the Hadoop BaseSource interface, which does allow for custom > metrics. Simply having the two wrappers implement BaseSource as well with > pass-through methods should be straightforward, and would allow replication > endpoints to use these generic metric methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)