[ 
https://issues.apache.org/jira/browse/HBASE-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437266#comment-15437266
 ] 

Hudson commented on HBASE-16471:
--------------------------------

FAILURE: Integrated in Jenkins build HBase-0.98-on-Hadoop-1.1 #1265 (See 
[https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/1265/])
HBASE-16471 Region Server metrics context will be wrong when machine 
(ashishsinghi: rev 02badbdf9d069f515d3198c799d5575539bd0459)
* (edit) 
hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestRpcMetrics.java
* (edit) 
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/ipc/MetricsHBaseServerSourceFactory.java


> Region Server metrics context will be wrong when machine hostname contain 
> "master" word
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-16471
>                 URL: https://issues.apache.org/jira/browse/HBASE-16471
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.0.0, 1.3.0, 0.98.21
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>            Priority: Minor
>             Fix For: 2.0.0, 1.3.0, 1.4.0, 1.1.6, 1.2.3, 0.98.22
>
>         Attachments: HBASE-16471-0.98.patch, HBASE-16471-V2.patch, 
> HBASE-16471.patch
>
>
> While initializing RSRpcServices server name is formed as,
> {code}
>     String name = rs.getProcessName() + "/" + initialIsa.toString();
> {code}
> So name will be like "regionserver/host_Name/host_IP:port".
> During MetricsHBaseServer intializing, we create server context name using 
> String contains() which will be wrong when machine hostname contain "master" 
> words.
> In MetricsHBaseServerSourceFactory, 
> {code}
>   protected static String createContextName(String serverName) {
>     if (serverName.contains("HMaster") || serverName.contains("master")) {
>       return "Master";
>     } else if (serverName.contains("HRegion") || 
> serverName.contains("regionserver")) {
>       return "RegionServer";
>     }
>     return "IPC";
>   }
> {code}
> For example, "regionserver/node-master1-xyz/host-IP:16020"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to