[ 
https://issues.apache.org/jira/browse/HBASE-4440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160552#comment-13160552
 ] 

Nicolas Spiegelberg commented on HBASE-4440:
--------------------------------------------

looks pretty good.  I wish you could use RegionSplitter.HexStringSplit to 
generate your keys (since that would be the recommended usage pattern), but I 
guess PerformanceEvaluation does DecimalStrings instead.  Maybe a refactoring 
effort?

The line
{code}
Thread.sleep(3000); // wait for things to settle down
{code}

deleteTable() should stall until all all the regions associated with that table 
are removed.  Did you encounter some problems without that sleep?  We shouldn't 
have any arbitrary stalls in the code and instead understand what else we need 
to wait on before creating the table again.
                
> add an option to presplit table to PerformanceEvaluation
> --------------------------------------------------------
>
>                 Key: HBASE-4440
>                 URL: https://issues.apache.org/jira/browse/HBASE-4440
>             Project: HBase
>          Issue Type: Improvement
>          Components: util
>            Reporter: Sujee Maniyam
>            Priority: Minor
>              Labels: benchmark
>         Attachments: PerformanceEvaluation.java, 
> PerformanceEvaluation_HBASE_4440.patch
>
>
> PerformanceEvaluation a quick way to 'benchmark' a HBase cluster.  The 
> current 'write*' operations do not pre-split the table.  Pre splitting the 
> table will really boost the insert performance.
> It would be nice to have an option to enable pre-splitting table before the 
> inserts begin.
> it would look something like:
> (a) hbase ...PerformanceEvaluation   --presplit=10 <other options>
> (b) hbase ...PerformanceEvaluation   --presplit <other options>
> (b) will try to presplit the table on some default value (say number of 
> region servers)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to