[
https://issues.apache.org/jira/browse/HBASE-16528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15450502#comment-15450502
]
Stephen Yuan Jiang commented on HBASE-16528:
--------------------------------------------
In UT, non-system users also trigger the ServerCrashProcure (and we currently
don't have code to prevent this to happen). This is not the reason that I
don't use 'Superusers.getSystemUser()', the reason is that currently we have
the following logic that we will get system user anyway if it is not from
non-system user (this covers all cases - though I don't know whether we can
assume that if user == null, it is 100% system user):
{code}
public User getRequestUser() {
User user = RpcServer.getRequestUser();
if (user == null) {
user = Superusers.getSystemUser();
}
return user;
}
{code}
> Procedure-V2: ServerCrashProcedure misses owner information
> -----------------------------------------------------------
>
> Key: HBASE-16528
> URL: https://issues.apache.org/jira/browse/HBASE-16528
> Project: HBase
> Issue Type: Bug
> Components: hbase, master, proc-v2
> Affects Versions: 2.0.0, 1.1.5
> Reporter: Stephen Yuan Jiang
> Assignee: Stephen Yuan Jiang
> Attachments: HBASE-16528.v1-master.patch, HBASE-16528.v2-master.patch
>
>
> ServerCrashProcedure constructor does not set up owner information. If
> someone wants to access the owner of ServerCrashProcedure, it would get NPE
> (eg. in case someone accidentally tries to abort a ServerCrashProcedure, the
> coprocessor to check owner of the procedure would throw NPE)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
