[
https://issues.apache.org/jira/browse/HBASE-4918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160639#comment-13160639
]
Hadoop QA commented on HBASE-4918:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12505715/HTablePool.java.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
-1 patch. The patch command could not apply the patch.
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/414//console
This message is automatically generated.
> HTablePool Constructor may cause unintended behavior
> ----------------------------------------------------
>
> Key: HBASE-4918
> URL: https://issues.apache.org/jira/browse/HBASE-4918
> Project: HBase
> Issue Type: Bug
> Components: client
> Environment: r1125533
> Reporter: Kitora, Naoki
> Attachments: HTablePool.java.patch
>
>
> {code:title=HTablePool.java}
> 96 public HTablePool(final Configuration config, final int maxSize,
> 97 final HTableInterfaceFactory tableFactory) {
> 98 this(config, maxSize, null, PoolType.Reusable);
> 99 }
> {code}
> I think that 3rd argument in line 98 should be "tableFactory".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
