[ 
https://issues.apache.org/jira/browse/HBASE-4847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160899#comment-13160899
 ] 

nkeywal commented on HBASE-4847:
--------------------------------

Well, as with this patch all small tests are executed in a shared jvm, we can 
see some side effects. However, I ran these test more than 20 times, and it's 
working in my env. I deactivated parallelism to avoid random results. So it's 
strange.

I went to the debugger for TestMinVersions#testBaseCase, and it seems the only 
to get this results is using a wrong EnvironmentEdgeManager. But I checked that 
only the default is used for small tests. The patch v7 add a check & a reset 
for the EnvironmentEdgeManager, I will see what are the results...
                
> Activate single jvm for small tests on jenkins
> ----------------------------------------------
>
>                 Key: HBASE-4847
>                 URL: https://issues.apache.org/jira/browse/HBASE-4847
>             Project: HBase
>          Issue Type: Improvement
>          Components: build, test
>    Affects Versions: 0.94.0
>         Environment: build
>            Reporter: nkeywal
>            Assignee: nkeywal
>            Priority: Minor
>         Attachments: 4847_all.v4.patch, 4847_all.v5.patch, 4847_all.v6.patch, 
> 4847_all.v6.patch, 4847_all.v7.patch, 4847_pom.patch, 4847_pom.v2.patch, 
> 4847_pom.v2.patch, 4847_pom.v2.patch, 4847_pom.v3.patch
>
>
> This will not revolutionate performances alone. We will win between 1 to 4 
> minutes.
> But we win as well:
>  - it's a step for parallelizing the tests
>  - new tests are less expensive as they do not create a new jvm: it's a 
> continuous win
>  - it will allow to push it on dev env while having the same env on dev & on 
> build, and 3 minutes are 10% of small + medium tests execution time.
> I will do a few "submit patch" to see if it works well before asking for the 
> real commit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to