[
https://issues.apache.org/jira/browse/HBASE-16399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15455178#comment-15455178
]
Vishal Khandelwal commented on HBASE-16399:
-------------------------------------------
This message is not required. I kept it for testing. We are already logging the
error when exception is caught
{code}
Updating Write Failure List from region:%s on region server
{code}
For this code earlier i thought move it main but then it is specific to region
scan. I think you are right we don't need this as error we are already printing
in catch and List is already given which can be consumed caller. i would
remove. mainly i had added this for my testing earlier.
{code}
Map<String,String> readFailures = sink.getReadFailures();
+ if(readFailures != null && readFailures.size() > 0){
+ LOG.info("==== Read Canary Failure Summary ===");
+ LOG.info("Region \t Server Name");
+ for(Map.Entry<String,String> e : readFailures.entrySet()) {
+ LOG.error(e.getKey() + "\t" + e.getValue());
+ }
+ }
+
+ Map<String,String> writeFailures = sink.getWriteFailures();
+ if(writeFailures != null && writeFailures.size() > 0){
+ LOG.info("==== Write Canary Failure Summary ===");
+ LOG.info("Region \t Server Name");
+ for(Map.Entry<String,String> e : writeFailures.entrySet()) {
+ LOG.error(e.getKey() + "\t" + e.getValue());
+ }
{code}
> Provide an API to get list of failed regions and servername in Canary
> ---------------------------------------------------------------------
>
> Key: HBASE-16399
> URL: https://issues.apache.org/jira/browse/HBASE-16399
> Project: HBase
> Issue Type: Improvement
> Components: canary
> Affects Versions: 1.3.1, 0.98.21
> Reporter: Vishal Khandelwal
> Assignee: Vishal Khandelwal
> Fix For: 1.3.1, 0.98.23
>
> Attachments: HBASE-16399.0.98.00.patch, HBASE-16399.0.98.01.patch,
> HBASE-16399.00.patch, HBASE-16399.01.patch, HBASE-16399.02.patch,
> HBASE-16399.branch-1.00.patch, HBASE-16399.branch-1.01.patch,
> HBASE-16399.branch-1.02.patch
>
>
> At present HBase Canary tool only prints the failures as part of logs. It
> does not provide an API to get the list or summarizes it so caller can take
> action on the failed host. This Jira would additional API so caller can get
> read or write canary failures.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
