[
https://issues.apache.org/jira/browse/HBASE-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459468#comment-15459468
]
Hudson commented on HBASE-16311:
--------------------------------
FAILURE: Integrated in Jenkins build HBase-1.4 #390 (See
[https://builds.apache.org/job/HBase-1.4/390/])
HBASE-16311 Audit log for delete snapshot operation is missing in case
(jerryjch: rev 8be6f95f99e776c5b46845cb42d1c2c03c25f802)
* (edit)
hbase-server/src/main/java/org/apache/hadoop/hbase/security/access/AccessController.java
* (edit)
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java
> Audit log for delete snapshot operation is missing in case of snapshot owner
> deleting the same
> ----------------------------------------------------------------------------------------------
>
> Key: HBASE-16311
> URL: https://issues.apache.org/jira/browse/HBASE-16311
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: 2.0.0
> Reporter: Abhishek Kumar
> Assignee: Yi Liang
> Priority: Minor
> Fix For: 2.0.0, 1.4.0
>
> Attachments: HBASE-16311-V1.patch, HBASE-16311-V2.patch,
> HBASE-16311-V3.patch, HBASE-16311-V4-branch-1.patch, HBASE-16311-V4.patch
>
>
> 1. Audit log seems to be left as a TODO task in AccessController.java:
> {code}
> @Override
> public void preDeleteSnapshot(final
> ObserverContext<MasterCoprocessorEnvironment> ctx,
> final SnapshotDescription snapshot) throws IOException {
> if (SnapshotDescriptionUtils.isSnapshotOwner(snapshot, getActiveUser())) {
> // Snapshot owner is allowed to delete the snapshot
> // TODO: We are not logging this for audit
> } else {
> requirePermission("deleteSnapshot", Action.ADMIN);
> }
> }
> {code}
> 2. Also, snapshot name is not getting logged in the audit logs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
