[
https://issues.apache.org/jira/browse/HBASE-14882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15461258#comment-15461258
]
Xiang Li commented on HBASE-14882:
----------------------------------
[~enis], thanks for the comments!
[~anoop.hbase] and [~enis]: The new implementation is extracted out of Put and
I put it into CellUtil as a public static inner class of CellUtil, and name it
as "InputsImmutableCell". Does it make sense to you?
The reason why putting it into CellUtil is that I found there are some Cell
implementations inside CellUtil, such as EmptyCell... But it will be placed
into a different package (not hbase.client as Put, but hbase) and a different
jar (not hbase-client.jar, but hbase-common.jar). Do you think it is reasonable
to put it there, or it is better to be placed in hbase.client, to be together
with Put?
> Provide a Put API that adds the provided family, qualifier, value without
> copying
> ---------------------------------------------------------------------------------
>
> Key: HBASE-14882
> URL: https://issues.apache.org/jira/browse/HBASE-14882
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 1.2.0
> Reporter: Jerry He
> Assignee: Xiang Li
> Fix For: 2.0.0
>
> Attachments: HBASE-14882.master.000.patch,
> HBASE-14882.master.001.patch
>
>
> In the Put API, we have addImmutable()
> {code}
> /**
> * See {@link #addColumn(byte[], byte[], byte[])}. This version expects
> * that the underlying arrays won't change. It's intended
> * for usage internal HBase to and for advanced client applications.
> */
> public Put addImmutable(byte [] family, byte [] qualifier, byte [] value)
> {code}
> But in the implementation, the family, qualifier and value are still being
> copied locally to create kv.
> Hopefully we should provide an API that truly uses immutable family,
> qualifier and value.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
