[
https://issues.apache.org/jira/browse/HBASE-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15465432#comment-15465432
]
Yu Li commented on HBASE-16505:
-------------------------------
bq. So we can just remove it. Yu Li What do you think?
Agreed, let's remove it.
bq. I think the findbugs warning is not an issue, we won't set exception
concurrently, even if we do this, any error is OK to throw.
If we set exception concurrently, there might be irrelative exception thrown
and confuse user. Else, I see no bad to set the method to be synchronized to
eliminate the findbugs warning. Wdyt?
bq. And what should we assert if we need a UT for RegionOperationContext?
Maybe something like {{testGetResultTimeout}} to make sure deadline setting
works, or create a MockAsyncRegion, always throw some exception in normal
append method, then make sure getResult will throw exception, etc.?
> Add AsyncRegion interface to pass deadline and support async operations
> -----------------------------------------------------------------------
>
> Key: HBASE-16505
> URL: https://issues.apache.org/jira/browse/HBASE-16505
> Project: HBase
> Issue Type: Sub-task
> Reporter: Phil Yang
> Assignee: Phil Yang
> Attachments: HBASE-16505-v1.patch, HBASE-16505-v2.patch,
> HBASE-16505-v3.patch, HBASE-16505-v4.patch, HBASE-16505-v5.patch
>
>
> If we want to know the correct setting of timeout in read/write path, we need
> add a new parameter in operation-methods of Region.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
