[
https://issues.apache.org/jira/browse/HBASE-16460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15466226#comment-15466226
]
Mikhail Antonov commented on HBASE-16460:
-----------------------------------------
[~te...@apache.org] thanks guys, this is a good catch. However I would really
like to limit commits to 1.3 for right now (maybe another 2-4 days) to critical
and blocker bugs, as I'm trying to see how stable the build is on real
workloads.
> Can't rebuild the BucketAllocator's data structures when BucketCache uses
> FileIOEngine
> --------------------------------------------------------------------------------------
>
> Key: HBASE-16460
> URL: https://issues.apache.org/jira/browse/HBASE-16460
> Project: HBase
> Issue Type: Bug
> Components: BucketCache
> Affects Versions: 2.0.0, 1.1.6, 1.3.1, 1.2.3, 0.98.22
> Reporter: Guanghao Zhang
> Assignee: Guanghao Zhang
> Fix For: 2.0.0, 1.3.0, 1.4.0, 1.1.7, 1.2.4
>
> Attachments: 16460.v6.patch, 16460.v6.patch,
> HBASE-16460-branch-1-v6.patch, HBASE-16460-v1.patch, HBASE-16460-v2.patch,
> HBASE-16460-v2.patch, HBASE-16460-v3.patch, HBASE-16460-v4.patch,
> HBASE-16460-v5.patch, HBASE-16460-v5.patch, HBASE-16460.patch
>
>
> When bucket cache use FileIOEngine, it will rebuild the bucket allocator's
> data structures from a persisted map. So it should first read the map from
> persistence file then use the map to new a BucketAllocator. But now the code
> has wrong sequence in retrieveFromFile() method of BucketCache.java.
> {code}
> BucketAllocator allocator = new BucketAllocator(cacheCapacity,
> bucketSizes, backingMap, realCacheSize);
> backingMap = (ConcurrentHashMap<BlockCacheKey, BucketEntry>)
> ois.readObject();
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
