[
https://issues.apache.org/jira/browse/HBASE-16576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472006#comment-15472006
]
Hadoop QA commented on HBASE-16576:
-----------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 12s
{color} | {color:blue} Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m
0s {color} | {color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s
{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s {color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m
1s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 7s
{color} | {color:green} master passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} master passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m
14s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m
15s {color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} rubocop {color} | {color:red} 0m 7s
{color} | {color:red} The patch generated 15 new + 158 unchanged - 14 fixed =
173 total (was 172) {color} |
| {color:red}-1{color} | {color:red} ruby-lint {color} | {color:red} 0m 6s
{color} | {color:red} The patch generated 4 new + 155 unchanged - 8 fixed = 159
total (was 163) {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s {color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green}
26m 55s {color} | {color:green} Patch does not cause any errors with Hadoop
2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} hbaseprotoc {color} | {color:green} 0m
11s {color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 7s
{color} | {color:green} the patch passed with JDK v1.8.0_101 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 9s
{color} | {color:green} the patch passed with JDK v1.7.0_111 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 6m 25s
{color} | {color:green} hbase-shell in the patch passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
7s {color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 38m 32s {color}
| {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.11.2 Server=1.11.2 Image:yetus/hbase:date2016-09-07 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/12827454/HBASE-16576.patch |
| JIRA Issue | HBASE-16576 |
| Optional Tests | asflicense javac javadoc unit rubocop ruby_lint |
| uname | Linux 1f2368f0ea82 3.13.0-92-generic #139-Ubuntu SMP Tue Jun 28
20:42:26 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / e9cfbfd |
| Default Java | 1.7.0_111 |
| Multi-JDK versions | /usr/lib/jvm/java-8-oracle:1.8.0_101
/usr/lib/jvm/java-7-openjdk-amd64:1.7.0_111 |
| rubocop | v0.42.0 |
| rubocop |
https://builds.apache.org/job/PreCommit-HBASE-Build/3443/artifact/patchprocess/diff-patch-rubocop.txt
|
| ruby-lint | v2.3.0 |
| ruby-lint |
https://builds.apache.org/job/PreCommit-HBASE-Build/3443/artifact/patchprocess/diff-patch-ruby-lint.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-HBASE-Build/3443/testReport/ |
| modules | C: hbase-shell U: hbase-shell |
| Console output |
https://builds.apache.org/job/PreCommit-HBASE-Build/3443/console |
| Powered by | Apache Yetus 0.3.0 http://yetus.apache.org |
This message was automatically generated.
> Shell add_peer doesn't allow setting cluster_key for custom endpoints
> ---------------------------------------------------------------------
>
> Key: HBASE-16576
> URL: https://issues.apache.org/jira/browse/HBASE-16576
> Project: HBase
> Issue Type: Bug
> Components: shell
> Affects Versions: 2.0.0, 1.1.5, 0.98.22
> Reporter: Geoffrey Jacoby
> Assignee: Geoffrey Jacoby
> Attachments: HBASE-16576.patch
>
>
> The HBase shell allows a user to create a replication peer using the add_peer
> method, which can take a peer id and a Ruby hash. It creates a
> ReplicationPeerConfig and passes it through to the Java
> ReplicationAdmin#addPeer.
> The Ruby code makes an assumption that the Java API doesn't: that CLUSTER_KEY
> and ENDPOINT_CLASSNAME are mutually exclusive. If both are specified, it
> throws an error. If only ENDPOINT_CLASSNAME is set, the add_peer logic
> derives a local dummy cluster key based on the local cluster's configuration.
> CLUSTER_KEY shouldn't be required when an ENDPOINT_CLASSNAME is specified,
> because a custom endpoint might not need it. The dummy default logic is fine.
>
> But if an endpoint does require a remote cluster key, it shouldn't be
> forbidden to provide one, especially since the Java API permits it, and even
> the custom replication endpoint Java tests rely on this. (See
> TestReplicationEndpoint#testCustomReplicationEndpoint)
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
