[
https://issues.apache.org/jira/browse/HBASE-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162041#comment-13162041
]
Phabricator commented on HBASE-4908:
------------------------------------
mbautin has commented on the revision "[jira] [HBASE-4908] HBase cluster test
tool (port from 0.89-fb)".
Some replies inline. I will remove HdfsAppender test as well -- it seems
unrelated to the main purpose of the load tester tool.
INLINE COMMENTS
src/test/java/org/apache/hadoop/hbase/manual/HBaseClusterTest.java:17 Moved
to org.apache.hadoop.hbase.util.
src/test/java/org/apache/hadoop/hbase/manual/HBaseClusterTest.java:92 Done.
src/test/java/org/apache/hadoop/hbase/manual/HBaseClusterTest.java:103 Made
20 a constant and removed separate logic for the (endKey - startKey) <= 1000
case.
src/test/java/org/apache/hadoop/hbase/manual/HBaseClusterTest.java:204
Mentioned this in the class comment.
src/test/java/org/apache/hadoop/hbase/manual/RestartMetaTest.java:36 Added.
src/test/java/org/apache/hadoop/hbase/manual/RestartMetaTest.java:152 There
is not a lot of overlap of functionality, but perhaps some overlap in
structure, e.g. command-line argument processing. I'd like to avoid doing a lot
of refactoring until the next iteration. Ideally it should be possible to run
every integration test both as a JUnit test and as a command-line tool.
REVISION DETAIL
https://reviews.facebook.net/D549
> HBase cluster test tool (port from 0.89-fb)
> -------------------------------------------
>
> Key: HBASE-4908
> URL: https://issues.apache.org/jira/browse/HBASE-4908
> Project: HBase
> Issue Type: Sub-task
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: D549.1.patch, D549.2.patch, D549.3.patch, D549.4.patch
>
>
> Porting one of our HBase cluster test tools (a single-process multi-threaded
> load generator and verifier) from 0.89-fb to trunk.
> I cleaned up the code a bit compared to what's in 0.89-fb, and discovered
> that it has some features that I have not tried yet (some kind of a kill
> test, and some way to run HBase as multiple processes on one machine).
> The main utility of this piece of code for us has been the HBaseClusterTest
> command-line tool (called HBaseTest in 0.89-fb), which we usually invoke as a
> load test in our five-node dev cluster testing, e.g.:
> hbase org.apache.hadoop.hbase.manual.HBaseTest -load 1000000000:50:100:20 -tn
> load_test -read 1:1000000000:50:20 -zk <zk_quorum> -bloom ROWCOL -compression
> GZIP
> I will be using this code to load-test the delta encoding patch and making
> fixes, but I am submitting the patch for early feedback. I will probably try
> out its other functionality and comment on how it works.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
